* [PATCH] Bluetooth: hci_sync: cancel cmd_timer if hci_open failed
@ 2022-10-05 7:09 Archie Pusaka
2022-10-05 7:35 ` bluez.test.bot
2022-10-11 19:40 ` [PATCH] " patchwork-bot+bluetooth
0 siblings, 2 replies; 4+ messages in thread
From: Archie Pusaka @ 2022-10-05 7:09 UTC (permalink / raw)
To: linux-bluetooth, Luiz Augusto von Dentz, Marcel Holtmann
Cc: CrosBT Upstreaming, Archie Pusaka, Abhishek Pandit-Subedi,
David S. Miller, Eric Dumazet, Jakub Kicinski, Johan Hedberg,
Paolo Abeni, linux-kernel, netdev
From: Archie Pusaka <apusaka@chromium.org>
If a command is already sent, we take care of freeing it, but we
also need to cancel the timeout as well.
Signed-off-by: Archie Pusaka <apusaka@chromium.org>
Reviewed-by: Abhishek Pandit-Subedi <abhishekpandit@google.com>
---
net/bluetooth/hci_sync.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c
index 76c3107c9f91..a011065220e4 100644
--- a/net/bluetooth/hci_sync.c
+++ b/net/bluetooth/hci_sync.c
@@ -4696,6 +4696,7 @@ int hci_dev_open_sync(struct hci_dev *hdev)
hdev->flush(hdev);
if (hdev->sent_cmd) {
+ cancel_delayed_work_sync(&hdev->cmd_timer);
kfree_skb(hdev->sent_cmd);
hdev->sent_cmd = NULL;
}
--
2.38.0.rc1.362.ged0d419d3c-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: Bluetooth: hci_sync: cancel cmd_timer if hci_open failed
2022-10-05 7:09 [PATCH] Bluetooth: hci_sync: cancel cmd_timer if hci_open failed Archie Pusaka
@ 2022-10-05 7:35 ` bluez.test.bot
2022-10-11 19:40 ` [PATCH] " patchwork-bot+bluetooth
1 sibling, 0 replies; 4+ messages in thread
From: bluez.test.bot @ 2022-10-05 7:35 UTC (permalink / raw)
To: linux-bluetooth, apusaka
[-- Attachment #1: Type: text/plain, Size: 1206 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=683158
---Test result---
Test Summary:
CheckPatch PASS 2.38 seconds
GitLint PASS 0.79 seconds
SubjectPrefix PASS 0.69 seconds
BuildKernel PASS 49.88 seconds
BuildKernel32 PASS 41.45 seconds
Incremental Build with patchesPASS 54.45 seconds
TestRunner: Setup PASS 731.82 seconds
TestRunner: l2cap-tester PASS 17.16 seconds
TestRunner: iso-tester PASS 16.55 seconds
TestRunner: bnep-tester PASS 6.21 seconds
TestRunner: mgmt-tester PASS 106.64 seconds
TestRunner: rfcomm-tester PASS 10.10 seconds
TestRunner: sco-tester PASS 9.29 seconds
TestRunner: ioctl-tester PASS 10.61 seconds
TestRunner: smp-tester PASS 9.48 seconds
TestRunner: userchan-tester PASS 6.49 seconds
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Bluetooth: hci_sync: cancel cmd_timer if hci_open failed
2022-10-05 7:09 [PATCH] Bluetooth: hci_sync: cancel cmd_timer if hci_open failed Archie Pusaka
2022-10-05 7:35 ` bluez.test.bot
@ 2022-10-11 19:40 ` patchwork-bot+bluetooth
1 sibling, 0 replies; 4+ messages in thread
From: patchwork-bot+bluetooth @ 2022-10-11 19:40 UTC (permalink / raw)
To: Archie Pusaka
Cc: linux-bluetooth, luiz.dentz, marcel,
chromeos-bluetooth-upstreaming, apusaka, abhishekpandit, davem,
edumazet, kuba, johan.hedberg, pabeni, linux-kernel, netdev
Hello:
This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:
On Wed, 5 Oct 2022 15:09:47 +0800 you wrote:
> From: Archie Pusaka <apusaka@chromium.org>
>
> If a command is already sent, we take care of freeing it, but we
> also need to cancel the timeout as well.
>
> Signed-off-by: Archie Pusaka <apusaka@chromium.org>
> Reviewed-by: Abhishek Pandit-Subedi <abhishekpandit@google.com>
>
> [...]
Here is the summary with links:
- Bluetooth: hci_sync: cancel cmd_timer if hci_open failed
https://git.kernel.org/bluetooth/bluetooth-next/c/64b5c4c8e79c
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: Bluetooth: hci_sync: cancel cmd_timer if hci_open failed
2023-01-26 13:36 [PATCH 6.1 1/1] " Fedor Pchelkin
@ 2023-01-26 13:43 ` bluez.test.bot
0 siblings, 0 replies; 4+ messages in thread
From: bluez.test.bot @ 2023-01-26 13:43 UTC (permalink / raw)
To: linux-bluetooth, pchelkin
[-- Attachment #1: Type: text/plain, Size: 551 bytes --]
This is an automated email and please do not reply to this email.
Dear Submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
While preparing the CI tests, the patches you submitted couldn't be applied to the current HEAD of the repository.
----- Output -----
error: patch failed: net/bluetooth/hci_sync.c:4703
error: net/bluetooth/hci_sync.c: patch does not apply
hint: Use 'git am --show-current-patch' to see the failed patch
Please resolve the issue and submit the patches again.
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-01-26 13:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-05 7:09 [PATCH] Bluetooth: hci_sync: cancel cmd_timer if hci_open failed Archie Pusaka
2022-10-05 7:35 ` bluez.test.bot
2022-10-11 19:40 ` [PATCH] " patchwork-bot+bluetooth
2023-01-26 13:36 [PATCH 6.1 1/1] " Fedor Pchelkin
2023-01-26 13:43 ` bluez.test.bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).