Linux-Bluetooth Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] Bluetooth: Return NOTIFY_DONE for hci_suspend_notifier
@ 2020-07-23 10:47 max.chou
  2020-07-28  7:13 ` Marcel Holtmann
  0 siblings, 1 reply; 2+ messages in thread
From: max.chou @ 2020-07-23 10:47 UTC (permalink / raw)
  To: marcel, johan.hedberg, davem, kuba
  Cc: linux-bluetooth, netdev, linux-kernel, alex_lu, hildawu, max.chou

From: Max Chou <max.chou@realtek.com>

The original return is NOTIFY_STOP, but notifier_call_chain would stop
the future call for register_pm_notifier even registered on other Kernel
modules with the same priority which value is zero.

Signed-off-by: Max Chou <max.chou@realtek.com>
---
 net/bluetooth/hci_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
index 6509f785dd14..3ce06347216a 100644
--- a/net/bluetooth/hci_core.c
+++ b/net/bluetooth/hci_core.c
@@ -3513,7 +3513,7 @@ static int hci_suspend_notifier(struct notifier_block *nb, unsigned long action,
 		bt_dev_err(hdev, "Suspend notifier action (%lu) failed: %d",
 			   action, ret);
 
-	return NOTIFY_STOP;
+	return NOTIFY_DONE;
 }
 
 /* Alloc HCI device */
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Bluetooth: Return NOTIFY_DONE for hci_suspend_notifier
  2020-07-23 10:47 [PATCH] Bluetooth: Return NOTIFY_DONE for hci_suspend_notifier max.chou
@ 2020-07-28  7:13 ` Marcel Holtmann
  0 siblings, 0 replies; 2+ messages in thread
From: Marcel Holtmann @ 2020-07-28  7:13 UTC (permalink / raw)
  To: max.chou
  Cc: Johan Hedberg, David S. Miller, Jakub Kicinski, linux-bluetooth,
	netdev, linux-kernel, alex_lu, hildawu

Hi Max,

> The original return is NOTIFY_STOP, but notifier_call_chain would stop
> the future call for register_pm_notifier even registered on other Kernel
> modules with the same priority which value is zero.
> 
> Signed-off-by: Max Chou <max.chou@realtek.com>
> ---
> net/bluetooth/hci_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-23 10:47 [PATCH] Bluetooth: Return NOTIFY_DONE for hci_suspend_notifier max.chou
2020-07-28  7:13 ` Marcel Holtmann

Linux-Bluetooth Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-bluetooth/0 linux-bluetooth/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-bluetooth linux-bluetooth/ https://lore.kernel.org/linux-bluetooth \
		linux-bluetooth@vger.kernel.org
	public-inbox-index linux-bluetooth

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-bluetooth


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git