Linux-Bluetooth Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH -next] Bluetooth: hci_qca: Use vfree() instead of kfree()
@ 2020-01-08  3:59 Wei Yongjun
  2020-01-08 12:31 ` bgodavar
  2020-01-08 20:46 ` Marcel Holtmann
  0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2020-01-08  3:59 UTC (permalink / raw)
  To: Marcel Holtmann, Johan Hedberg, Balakrishna Godavarthi
  Cc: Wei Yongjun, linux-bluetooth, kernel-janitors

Use vfree() instead of kfree() to free vmalloc()
allocated data.

Fixes: d841502c79e3 ("Bluetooth: hci_qca: Collect controller memory dump during SSR")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/bluetooth/hci_qca.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
index 9392cc7f9908..a17260641283 100644
--- a/drivers/bluetooth/hci_qca.c
+++ b/drivers/bluetooth/hci_qca.c
@@ -529,7 +529,7 @@ static void hci_memdump_timeout(struct timer_list *t)
 	bt_dev_err(hu->hdev, "clearing allocated memory due to memdump timeout");
 	/* Inject hw error event to reset the device and driver. */
 	hci_reset_dev(hu->hdev);
-	kfree(memdump_buf);
+	vfree(memdump_buf);
 	kfree(qca_memdump);
 	qca->memdump_state = QCA_MEMDUMP_TIMEOUT;
 	del_timer(&qca->memdump_timer);
@@ -1437,7 +1437,7 @@ static void qca_wait_for_dump_collection(struct hci_dev *hdev)
 		bt_dev_err(hu->hdev, "Clearing the buffers due to timeout");
 		if (qca_memdump)
 			memdump_buf = qca_memdump->memdump_buf_tail;
-		kfree(memdump_buf);
+		vfree(memdump_buf);
 		kfree(qca_memdump);
 		qca->memdump_state = QCA_MEMDUMP_TIMEOUT;
 		del_timer(&qca->memdump_timer);




^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] Bluetooth: hci_qca: Use vfree() instead of kfree()
  2020-01-08  3:59 [PATCH -next] Bluetooth: hci_qca: Use vfree() instead of kfree() Wei Yongjun
@ 2020-01-08 12:31 ` bgodavar
  2020-01-08 20:46 ` Marcel Holtmann
  1 sibling, 0 replies; 3+ messages in thread
From: bgodavar @ 2020-01-08 12:31 UTC (permalink / raw)
  To: Wei Yongjun
  Cc: Marcel Holtmann, Johan Hedberg, linux-bluetooth, kernel-janitors,
	hemantg

On 2020-01-08 09:29, Wei Yongjun wrote:
> Use vfree() instead of kfree() to free vmalloc()
> allocated data.
> 
> Fixes: d841502c79e3 ("Bluetooth: hci_qca: Collect controller memory
> dump during SSR")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
>  drivers/bluetooth/hci_qca.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
> index 9392cc7f9908..a17260641283 100644
> --- a/drivers/bluetooth/hci_qca.c
> +++ b/drivers/bluetooth/hci_qca.c
> @@ -529,7 +529,7 @@ static void hci_memdump_timeout(struct timer_list 
> *t)
>  	bt_dev_err(hu->hdev, "clearing allocated memory due to memdump 
> timeout");
>  	/* Inject hw error event to reset the device and driver. */
>  	hci_reset_dev(hu->hdev);
> -	kfree(memdump_buf);
> +	vfree(memdump_buf);
>  	kfree(qca_memdump);
>  	qca->memdump_state = QCA_MEMDUMP_TIMEOUT;
>  	del_timer(&qca->memdump_timer);
> @@ -1437,7 +1437,7 @@ static void qca_wait_for_dump_collection(struct
> hci_dev *hdev)
>  		bt_dev_err(hu->hdev, "Clearing the buffers due to timeout");
>  		if (qca_memdump)
>  			memdump_buf = qca_memdump->memdump_buf_tail;
> -		kfree(memdump_buf);
> +		vfree(memdump_buf);
>  		kfree(qca_memdump);
>  		qca->memdump_state = QCA_MEMDUMP_TIMEOUT;
>  		del_timer(&qca->memdump_timer);

Reviewed-by: Balakrishna Godavarthi <bgodavar@codeaurora.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] Bluetooth: hci_qca: Use vfree() instead of kfree()
  2020-01-08  3:59 [PATCH -next] Bluetooth: hci_qca: Use vfree() instead of kfree() Wei Yongjun
  2020-01-08 12:31 ` bgodavar
@ 2020-01-08 20:46 ` Marcel Holtmann
  1 sibling, 0 replies; 3+ messages in thread
From: Marcel Holtmann @ 2020-01-08 20:46 UTC (permalink / raw)
  To: Wei Yongjun
  Cc: Johan Hedberg, Balakrishna Godavarthi, linux-bluetooth, kernel-janitors

Hi Wei,

> Use vfree() instead of kfree() to free vmalloc()
> allocated data.
> 
> Fixes: d841502c79e3 ("Bluetooth: hci_qca: Collect controller memory dump during SSR")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/bluetooth/hci_qca.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-08  3:59 [PATCH -next] Bluetooth: hci_qca: Use vfree() instead of kfree() Wei Yongjun
2020-01-08 12:31 ` bgodavar
2020-01-08 20:46 ` Marcel Holtmann

Linux-Bluetooth Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-bluetooth/0 linux-bluetooth/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-bluetooth linux-bluetooth/ https://lore.kernel.org/linux-bluetooth \
		linux-bluetooth@vger.kernel.org
	public-inbox-index linux-bluetooth

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-bluetooth


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git