From: Marcel Holtmann <marcel@holtmann.org>
To: Tedd Ho-Jeong An <hj.tedd.an@gmail.com>
Cc: linux-bluetooth <linux-bluetooth@vger.kernel.org>,
Tedd Ho-Jeong An <tedd.an@intel.com>
Subject: Re: [RFC PATCH] Bluetooth: hci_vhci: Fix to set force_wakeup value
Date: Sat, 2 Oct 2021 22:52:26 +0200 [thread overview]
Message-ID: <86E45D71-62B4-4ED0-A31A-FB021D86F9B3@holtmann.org> (raw)
In-Reply-To: <20211002182109.165456-1-hj.tedd.an@gmail.com>
Hi Tedd,
> This patch sets the wakeup value in the vhci driver data after reading
> the value.
>
> Signed-off-by: Tedd Ho-Jeong An <tedd.an@intel.com>
> ---
> drivers/bluetooth/hci_vhci.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/bluetooth/hci_vhci.c b/drivers/bluetooth/hci_vhci.c
> index b45db0db347c..5fd91106e853 100644
> --- a/drivers/bluetooth/hci_vhci.c
> +++ b/drivers/bluetooth/hci_vhci.c
> @@ -176,6 +176,8 @@ static ssize_t force_wakeup_write(struct file *file,
> if (data->wakeup == enable)
> return -EALREADY;
>
> + data->wakeup = enable;
> +
> return count;
patch looks good, but the commit message is confusing.
Regards
Marcel
next prev parent reply other threads:[~2021-10-02 20:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-02 18:21 [RFC PATCH] Bluetooth: hci_vhci: Fix to set force_wakeup value Tedd Ho-Jeong An
2021-10-02 20:52 ` Marcel Holtmann [this message]
2021-10-04 22:27 ` Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86E45D71-62B4-4ED0-A31A-FB021D86F9B3@holtmann.org \
--to=marcel@holtmann.org \
--cc=hj.tedd.an@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=tedd.an@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).