From: Marcel Holtmann <marcel@holtmann.org>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: Kiran K <kiran.k@intel.com>,
"linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH v10 10/10] Bluetooth: Add offload feature under experimental flag
Date: Thu, 22 Jul 2021 19:59:43 +0200 [thread overview]
Message-ID: <87EBBD58-71B1-4712-A5BC-8B53E739DAFE@holtmann.org> (raw)
In-Reply-To: <CABBYNZKMrq_6Rb9rJKhMU-w=WjznQsVc=yYfDVuxKtEjvtNLdw@mail.gmail.com>
Hi Luiz,
>>>> Allow user level process to enable / disable codec offload
>>>> feature through mgmt interface. By default offload codec feature
>>>> is disabled.
>>>>
>>>> Signed-off-by: Kiran K <kiran.k@intel.com>
>>>> Reviewed-by: Chethan T N <chethan.tumkur.narayan@intel.com>
>>>> Reviewed-by: Srivatsa Ravishankar <ravishankar.srivatsa@intel.com>
>>>> ---
>>>> * changes in v10:
>>>> - new patch added to place offload codec feature under experimental flag
>>>>
>>>> include/net/bluetooth/hci.h | 4 ++
>>>> net/bluetooth/mgmt.c | 106 +++++++++++++++++++++++++++++++++++-
>>>> net/bluetooth/sco.c | 10 ++++
>>>> 3 files changed, 119 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/include/net/bluetooth/hci.h b/include/net/bluetooth/hci.h
>>>> index e20318854900..5ca98d9f64dd 100644
>>>> --- a/include/net/bluetooth/hci.h
>>>> +++ b/include/net/bluetooth/hci.h
>>>> @@ -331,6 +331,10 @@ enum {
>>>> HCI_CMD_PENDING,
>>>> HCI_FORCE_NO_MITM,
>>>>
>>>> +#if IS_ENABLED(CONFIG_BT_OFFLOAD_CODECS)
>>>> + HCI_OFFLOAD_CODECS_ENABLED,
>>>> +#endif
>>>
>>> That is probably a bad idea as it could lead the enum to assume
>>> different values based on what is enabled, besides we don't gain
>>> anything by not having the symbol defined all the time.
>>
>> While this would work with dev_flags which are internal and not API, I still don’t like it.
>>
>> There is really no benefit to make this a compile time option. And as far as I remember I never said this needs to be compile time. Actually I rather have this as an experimental setting so that it can be switched on at runtime. Nobody is going to recompile their kernels to test codec offload.
>
> Initially I was with the same opinion, but the problem is the codecs
> are read at init sequence and the experimental flags are set at a
> later stage thus why I suggested a KConfig option until the feature is
> more mature and we can remove the option altogether.
I am fine with the codec options being read all the time. I mean having an experimental option to control the use of offload.
Regards
Marcel
next prev parent reply other threads:[~2021-07-22 17:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-30 8:07 [PATCH v10 01/10] Bluetooth: Enumerate local supported codec and cache details Kiran K
2021-06-30 8:07 ` [PATCH v10 02/10] Bluetooth: Add support for Read Local Supported Codecs V2 Kiran K
2021-06-30 8:08 ` [PATCH v10 03/10] Bluetooth: btintel: Read supported offload usecases Kiran K
2021-06-30 8:08 ` [PATCH v10 04/10] Bluetooth: Allow querying of supported offload codecs over SCO socket Kiran K
2021-06-30 8:08 ` [PATCH v10 05/10] Bluetooth: btintel: Define callback to fetch data_path_id Kiran K
2021-06-30 8:08 ` [PATCH v10 06/10] Bluetooth: Allow setting of codec for HFP offload usecase Kiran K
2021-06-30 8:08 ` [PATCH v10 07/10] Bluetooth: btintel: Define a callback to fetch codec config data Kiran K
2021-06-30 8:08 ` [PATCH v10 08/10] Bluetooth: Add support for HCI_Enhanced_Setup_Synchronous_Connection command Kiran K
2021-06-30 20:39 ` Luiz Augusto von Dentz
2021-07-27 7:19 ` K, Kiran
2021-06-30 8:08 ` [PATCH v10 09/10] Bluetooth: Add support for msbc coding format Kiran K
2021-06-30 8:08 ` [PATCH v10 10/10] Bluetooth: Add offload feature under experimental flag Kiran K
2021-06-30 19:56 ` Luiz Augusto von Dentz
2021-07-22 14:01 ` Marcel Holtmann
2021-07-22 17:42 ` Luiz Augusto von Dentz
2021-07-22 17:59 ` Marcel Holtmann [this message]
2021-07-22 18:07 ` Luiz Augusto von Dentz
2021-07-22 18:50 ` Marcel Holtmann
2021-07-27 7:21 ` K, Kiran
2021-06-30 9:12 ` [v10,01/10] Bluetooth: Enumerate local supported codec and cache details bluez.test.bot
2021-06-30 20:15 ` [PATCH v10 01/10] " Luiz Augusto von Dentz
2021-07-27 6:56 ` K, Kiran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87EBBD58-71B1-4712-A5BC-8B53E739DAFE@holtmann.org \
--to=marcel@holtmann.org \
--cc=kiran.k@intel.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).