Linux-Bluetooth Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH BlueZ] Add a presubmit configuration file for Chromium OS repo
@ 2020-07-17 23:14 Sonny Sasaka
  2020-07-22 20:34 ` Sonny Sasaka
  2020-07-28  7:14 ` Marcel Holtmann
  0 siblings, 2 replies; 3+ messages in thread
From: Sonny Sasaka @ 2020-07-17 23:14 UTC (permalink / raw)
  To: linux-bluetooth; +Cc: Sonny Sasaka

Chromium OS developers use gerrit and repo in their workflow.
(https://gerrit.googlesource.com/git-repo/). This configuration file
makes it easier when uploading patches to gerrit with the repo tool.

---
 PRESUBMIT.cfg | 8 ++++++++
 1 file changed, 8 insertions(+)
 create mode 100644 PRESUBMIT.cfg

diff --git a/PRESUBMIT.cfg b/PRESUBMIT.cfg
new file mode 100644
index 000000000..10f89b741
--- /dev/null
+++ b/PRESUBMIT.cfg
@@ -0,0 +1,8 @@
+# This is a configuration for Chromium OS repo pre-upload hooks.
+# repohooks doc: https://chromium.googlesource.com/chromiumos/repohooks/
+# Chromium OS BlueZ git repo: https://chromium.googlesource.com/chromiumos/third_party/bluez/
+
+[Hook Overrides]
+cros_license_check: false
+tab_check: false
+checkpatch_check: true
-- 
2.26.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH BlueZ] Add a presubmit configuration file for Chromium OS repo
  2020-07-17 23:14 [PATCH BlueZ] Add a presubmit configuration file for Chromium OS repo Sonny Sasaka
@ 2020-07-22 20:34 ` Sonny Sasaka
  2020-07-28  7:14 ` Marcel Holtmann
  1 sibling, 0 replies; 3+ messages in thread
From: Sonny Sasaka @ 2020-07-22 20:34 UTC (permalink / raw)
  To: BlueZ

Maintainers, could you take a look at this? We started using a mirror
of upstream in chromium repo, so we can not apply this PRESUBMIT.cfg
file as our own commit. It'd be great if this file can be submitted
upstream as well to help Chromium OS developers' workflow.

On Fri, Jul 17, 2020 at 4:14 PM Sonny Sasaka <sonnysasaka@chromium.org> wrote:
>
> Chromium OS developers use gerrit and repo in their workflow.
> (https://gerrit.googlesource.com/git-repo/). This configuration file
> makes it easier when uploading patches to gerrit with the repo tool.
>
> ---
>  PRESUBMIT.cfg | 8 ++++++++
>  1 file changed, 8 insertions(+)
>  create mode 100644 PRESUBMIT.cfg
>
> diff --git a/PRESUBMIT.cfg b/PRESUBMIT.cfg
> new file mode 100644
> index 000000000..10f89b741
> --- /dev/null
> +++ b/PRESUBMIT.cfg
> @@ -0,0 +1,8 @@
> +# This is a configuration for Chromium OS repo pre-upload hooks.
> +# repohooks doc: https://chromium.googlesource.com/chromiumos/repohooks/
> +# Chromium OS BlueZ git repo: https://chromium.googlesource.com/chromiumos/third_party/bluez/
> +
> +[Hook Overrides]
> +cros_license_check: false
> +tab_check: false
> +checkpatch_check: true
> --
> 2.26.2
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH BlueZ] Add a presubmit configuration file for Chromium OS repo
  2020-07-17 23:14 [PATCH BlueZ] Add a presubmit configuration file for Chromium OS repo Sonny Sasaka
  2020-07-22 20:34 ` Sonny Sasaka
@ 2020-07-28  7:14 ` Marcel Holtmann
  1 sibling, 0 replies; 3+ messages in thread
From: Marcel Holtmann @ 2020-07-28  7:14 UTC (permalink / raw)
  To: Sonny Sasaka; +Cc: linux-bluetooth

Hi Sonny,

> Chromium OS developers use gerrit and repo in their workflow.
> (https://gerrit.googlesource.com/git-repo/). This configuration file
> makes it easier when uploading patches to gerrit with the repo tool.
> 
> ---
> PRESUBMIT.cfg | 8 ++++++++
> 1 file changed, 8 insertions(+)
> create mode 100644 PRESUBMIT.cfg
> 
> diff --git a/PRESUBMIT.cfg b/PRESUBMIT.cfg
> new file mode 100644
> index 000000000..10f89b741
> --- /dev/null
> +++ b/PRESUBMIT.cfg
> @@ -0,0 +1,8 @@
> +# This is a configuration for Chromium OS repo pre-upload hooks.
> +# repohooks doc: https://chromium.googlesource.com/chromiumos/repohooks/
> +# Chromium OS BlueZ git repo: https://chromium.googlesource.com/chromiumos/third_party/bluez/
> +
> +[Hook Overrides]
> +cros_license_check: false
> +tab_check: false
> +checkpatch_check: true

I am not in favor of adding anything in the top-level directory that is not for for the BlueZ upstream usage.

Regards

Marcel


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-17 23:14 [PATCH BlueZ] Add a presubmit configuration file for Chromium OS repo Sonny Sasaka
2020-07-22 20:34 ` Sonny Sasaka
2020-07-28  7:14 ` Marcel Holtmann

Linux-Bluetooth Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-bluetooth/0 linux-bluetooth/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-bluetooth linux-bluetooth/ https://lore.kernel.org/linux-bluetooth \
		linux-bluetooth@vger.kernel.org
	public-inbox-index linux-bluetooth

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-bluetooth


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git