* [PATCH] Bluetooth: hci_h4: Remove a redundant assignment in 'h4_flush()'
@ 2020-02-28 5:01 Christophe JAILLET
2020-02-28 7:44 ` Marcel Holtmann
0 siblings, 1 reply; 2+ messages in thread
From: Christophe JAILLET @ 2020-02-28 5:01 UTC (permalink / raw)
To: marcel, johan.hedberg
Cc: linux-bluetooth, linux-kernel, kernel-janitors, Christophe JAILLET
'hu->priv' is set twice to NULL in this function.
Axe one of these assignments.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/bluetooth/hci_h4.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/bluetooth/hci_h4.c b/drivers/bluetooth/hci_h4.c
index 6dc1fbeb564b..0b84a05a730b 100644
--- a/drivers/bluetooth/hci_h4.c
+++ b/drivers/bluetooth/hci_h4.c
@@ -71,8 +71,6 @@ static int h4_close(struct hci_uart *hu)
{
struct h4_struct *h4 = hu->priv;
- hu->priv = NULL;
-
BT_DBG("hu %p", hu);
skb_queue_purge(&h4->txq);
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Bluetooth: hci_h4: Remove a redundant assignment in 'h4_flush()'
2020-02-28 5:01 [PATCH] Bluetooth: hci_h4: Remove a redundant assignment in 'h4_flush()' Christophe JAILLET
@ 2020-02-28 7:44 ` Marcel Holtmann
0 siblings, 0 replies; 2+ messages in thread
From: Marcel Holtmann @ 2020-02-28 7:44 UTC (permalink / raw)
To: Christophe JAILLET
Cc: Johan Hedberg, linux-bluetooth, linux-kernel, kernel-janitors
Hi Christophe,
> 'hu->priv' is set twice to NULL in this function.
> Axe one of these assignments.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/bluetooth/hci_h4.c | 2 --
> 1 file changed, 2 deletions(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-28 7:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-28 5:01 [PATCH] Bluetooth: hci_h4: Remove a redundant assignment in 'h4_flush()' Christophe JAILLET
2020-02-28 7:44 ` Marcel Holtmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).