* [PATCH v2] Bluetooth: btrtl: Add null check in setup @ 2021-01-06 4:58 Abhishek Pandit-Subedi 2021-01-06 5:35 ` [v2] " bluez.test.bot 2021-01-06 7:50 ` [PATCH v2] " Marcel Holtmann 0 siblings, 2 replies; 3+ messages in thread From: Abhishek Pandit-Subedi @ 2021-01-06 4:58 UTC (permalink / raw) To: marcel Cc: chromeos-bluetooth-upstreaming, linux-bluetooth, Abhishek Pandit-Subedi, Johan Hedberg, Daniel Winkler, linux-kernel, Luiz Augusto von Dentz btrtl_dev->ic_info is only available from the controller on cold boot (the lmp subversion matches the device model and this is used to look up the ic_info). On warm boots (firmware already loaded), btrtl_dev->ic_info is null. Fixes: 05672a2c14a4 (Bluetooth: btrtl: Enable central-peripheral role) Signed-off-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org> --- Changes in v2: - Added nullcheck with goto done drivers/bluetooth/btrtl.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c index 1abf6a4d6727..24f03a1f8d57 100644 --- a/drivers/bluetooth/btrtl.c +++ b/drivers/bluetooth/btrtl.c @@ -719,6 +719,9 @@ int btrtl_setup_realtek(struct hci_dev *hdev) */ set_bit(HCI_QUIRK_SIMULTANEOUS_DISCOVERY, &hdev->quirks); + if (!btrtl_dev->ic_info) + goto done; + /* Enable central-peripheral role (able to create new connections with * an existing connection in slave role). */ @@ -731,6 +734,7 @@ int btrtl_setup_realtek(struct hci_dev *hdev) break; } +done: btrtl_free(btrtl_dev); return ret; } -- 2.29.2.729.g45daf8777d-goog ^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [v2] Bluetooth: btrtl: Add null check in setup 2021-01-06 4:58 [PATCH v2] Bluetooth: btrtl: Add null check in setup Abhishek Pandit-Subedi @ 2021-01-06 5:35 ` bluez.test.bot 2021-01-06 7:50 ` [PATCH v2] " Marcel Holtmann 1 sibling, 0 replies; 3+ messages in thread From: bluez.test.bot @ 2021-01-06 5:35 UTC (permalink / raw) To: linux-bluetooth, abhishekpandit [-- Attachment #1: Type: text/plain, Size: 2008 bytes --] This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=409765 ---Test result--- ############################## Test: CheckPatch - PASS ############################## Test: CheckGitLint - FAIL workflow: Add workflow files for ci 1: T1 Title exceeds max length (92>72): "Merge 662230795a1a7c4cf6e0590540a9f4c4eac93be2 into a982edf3a75de4515632a1f18a5355af66140c0d" 3: B6 Body message is missing Bluetooth: btrtl: Add null check in setup 1: T1 Title exceeds max length (92>72): "Merge 662230795a1a7c4cf6e0590540a9f4c4eac93be2 into a982edf3a75de4515632a1f18a5355af66140c0d" 3: B6 Body message is missing ############################## Test: CheckBuildK - PASS ############################## Test: CheckTestRunner: Setup - PASS ############################## Test: CheckTestRunner: l2cap-tester - PASS Total: 40, Passed: 34 (85.0%), Failed: 0, Not Run: 6 ############################## Test: CheckTestRunner: bnep-tester - PASS Total: 1, Passed: 1 (100.0%), Failed: 0, Not Run: 0 ############################## Test: CheckTestRunner: mgmt-tester - PASS Total: 416, Passed: 402 (96.6%), Failed: 0, Not Run: 14 ############################## Test: CheckTestRunner: rfcomm-tester - PASS Total: 9, Passed: 9 (100.0%), Failed: 0, Not Run: 0 ############################## Test: CheckTestRunner: sco-tester - PASS Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0 ############################## Test: CheckTestRunner: smp-tester - PASS Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0 ############################## Test: CheckTestRunner: userchan-tester - PASS Total: 3, Passed: 3 (100.0%), Failed: 0, Not Run: 0 --- Regards, Linux Bluetooth [-- Attachment #2: l2cap-tester.log --] [-- Type: application/octet-stream, Size: 43339 bytes --] [-- Attachment #3: bnep-tester.log --] [-- Type: application/octet-stream, Size: 3528 bytes --] [-- Attachment #4: mgmt-tester.log --] [-- Type: application/octet-stream, Size: 546677 bytes --] [-- Attachment #5: rfcomm-tester.log --] [-- Type: application/octet-stream, Size: 11649 bytes --] [-- Attachment #6: sco-tester.log --] [-- Type: application/octet-stream, Size: 9885 bytes --] [-- Attachment #7: smp-tester.log --] [-- Type: application/octet-stream, Size: 11796 bytes --] [-- Attachment #8: userchan-tester.log --] [-- Type: application/octet-stream, Size: 5427 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] Bluetooth: btrtl: Add null check in setup 2021-01-06 4:58 [PATCH v2] Bluetooth: btrtl: Add null check in setup Abhishek Pandit-Subedi 2021-01-06 5:35 ` [v2] " bluez.test.bot @ 2021-01-06 7:50 ` Marcel Holtmann 1 sibling, 0 replies; 3+ messages in thread From: Marcel Holtmann @ 2021-01-06 7:50 UTC (permalink / raw) To: Abhishek Pandit-Subedi Cc: CrosBT Upstreaming, linux-bluetooth, Johan Hedberg, Daniel Winkler, LKML, Luiz Augusto von Dentz Hi Abhishek, > btrtl_dev->ic_info is only available from the controller on cold boot > (the lmp subversion matches the device model and this is used to look up > the ic_info). On warm boots (firmware already loaded), > btrtl_dev->ic_info is null. > > Fixes: 05672a2c14a4 (Bluetooth: btrtl: Enable central-peripheral role) > Signed-off-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org> > --- > > Changes in v2: > - Added nullcheck with goto done > > drivers/bluetooth/btrtl.c | 4 ++++ > 1 file changed, 4 insertions(+) patch has been applied to bluetooth-next tree. Regards Marcel ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-06 7:51 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-01-06 4:58 [PATCH v2] Bluetooth: btrtl: Add null check in setup Abhishek Pandit-Subedi 2021-01-06 5:35 ` [v2] " bluez.test.bot 2021-01-06 7:50 ` [PATCH v2] " Marcel Holtmann
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).