[BlueZ PATCH V2] btp: Update connect event structure

[BlueZ PATCH V2] btp: Update connect event structure

[Tedd Ho-Jeong An]

From: Tedd Ho-Jeong An <tedd.an@intel.com>

This patch updates the connect event struct to align withe the btp spec.

 Opcode 0x82 - Device Connected event
    Controller Index:   <controller id>
    Event parameters:   Address_Type (1 octet)
                        Address (6 octets)
                        Connection Interval (2 octets)
                        Connection Latency (2 octets)
                        Supervision Timeout (2 octets)
---
 src/shared/btp.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/shared/btp.h b/src/shared/btp.h
index f0ac3a1ee..cc71a71df 100644
--- a/src/shared/btp.h
+++ b/src/shared/btp.h
@@ -259,6 +259,9 @@ struct btp_device_found_ev {
 struct btp_gap_device_connected_ev {
 	uint8_t address_type;
 	bdaddr_t address;
+	uint16_t connection_interval;
+	uint16_t connection_latency;
+	uint16_t supervision_timeout;
 } __packed;
 
 #define BTP_EV_GAP_DEVICE_DISCONNECTED		0x83
-- 
2.17.1

Re: [BlueZ PATCH V2] btp: Update connect event structure

[Luiz Augusto von Dentz]

Hi Tedd,

On Thu, Jun 25, 2020 at 5:10 PM Tedd Ho-Jeong An
<tedd.an@linux.intel.com> wrote:
>
> From: Tedd Ho-Jeong An <tedd.an@intel.com>
>
> This patch updates the connect event struct to align withe the btp spec.
>
>  Opcode 0x82 - Device Connected event
>     Controller Index:   <controller id>
>     Event parameters:   Address_Type (1 octet)
>                         Address (6 octets)
>                         Connection Interval (2 octets)
>                         Connection Latency (2 octets)
>                         Supervision Timeout (2 octets)
> ---
>  src/shared/btp.h | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/src/shared/btp.h b/src/shared/btp.h
> index f0ac3a1ee..cc71a71df 100644
> --- a/src/shared/btp.h
> +++ b/src/shared/btp.h
> @@ -259,6 +259,9 @@ struct btp_device_found_ev {
>  struct btp_gap_device_connected_ev {
>         uint8_t address_type;
>         bdaddr_t address;
> +       uint16_t connection_interval;
> +       uint16_t connection_latency;
> +       uint16_t supervision_timeout;
>  } __packed;

This appears to be an API break, or we don't for BTP to be stable?

>  #define BTP_EV_GAP_DEVICE_DISCONNECTED         0x83
> --
> 2.17.1
>
>


-- 
Luiz Augusto von Dentz

Re: [BlueZ PATCH V2] btp: Update connect event structure

[Tedd Ho-Jeong An]

Hi Luiz

On Fri, 2020-06-26 at 09:58 -0700, Luiz Augusto von Dentz wrote:
> Hi Tedd,
> 
> On Thu, Jun 25, 2020 at 5:10 PM Tedd Ho-Jeong An
> <tedd.an@linux.intel.com> wrote:
> > From: Tedd Ho-Jeong An <tedd.an@intel.com>
> > 
> > This patch updates the connect event struct to align withe the btp spec.
> > 
> >  Opcode 0x82 - Device Connected event
> >     Controller Index:   <controller id>
> >     Event parameters:   Address_Type (1 octet)
> >                         Address (6 octets)
> >                         Connection Interval (2 octets)
> >                         Connection Latency (2 octets)
> >                         Supervision Timeout (2 octets)
> > ---
> >  src/shared/btp.h | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/src/shared/btp.h b/src/shared/btp.h
> > index f0ac3a1ee..cc71a71df 100644
> > --- a/src/shared/btp.h
> > +++ b/src/shared/btp.h
> > @@ -259,6 +259,9 @@ struct btp_device_found_ev {
> >  struct btp_gap_device_connected_ev {
> >         uint8_t address_type;
> >         bdaddr_t address;
> > +       uint16_t connection_interval;
> > +       uint16_t connection_latency;
> > +       uint16_t supervision_timeout;
> >  } __packed;
> 
> This appears to be an API break, or we don't for BTP to be stable?

It was old change and this patch was to align the change for BlueZ.
All other projects using BTP such as Zephyr and Mynewt are already using new
change.

> 
> >  #define BTP_EV_GAP_DEVICE_DISCONNECTED         0x83
> > --
> > 2.17.1
> > 
> > 
> 
>