From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: Ross Burton <ross.burton@intel.com>
Cc: "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH BlueZ v2] Makefile.am: add missing mkdir in rules generation
Date: Wed, 9 Oct 2019 18:01:35 +0300 [thread overview]
Message-ID: <CABBYNZJCwvSRL_AotOSaiEwSg7=8ZCUC=wEvrmtQrh9BUQ+pGQ@mail.gmail.com> (raw)
In-Reply-To: <20191008100156.3813-1-ross.burton@intel.com>
Hi Ross,
On Tue, Oct 8, 2019 at 1:04 PM Ross Burton <ross.burton@intel.com> wrote:
>
> In parallel out-of-tree builds it's possible that tools/*.rules are
> generated before the target directory has been implicitly created. Solve this by
> creating the directory before writing into it.
> ---
> Makefile.am | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Makefile.am b/Makefile.am
> index 2ac28b23d..e7bcd2366 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -589,6 +589,7 @@ src/builtin.h: src/genbuiltin $(builtin_sources)
> $(AM_V_GEN)$(srcdir)/src/genbuiltin $(builtin_modules) > $@
>
> tools/%.rules:
> + $(AM_V_at)$(MKDIR_P) tools
> $(AM_V_GEN)cp $(srcdir)/$(subst 97-,,$@) $@
>
> $(lib_libbluetooth_la_OBJECTS): $(local_headers)
> --
> 2.20.1
Applied, thanks.
--
Luiz Augusto von Dentz
prev parent reply other threads:[~2019-10-09 15:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 10:01 [PATCH BlueZ v2] Makefile.am: add missing mkdir in rules generation Ross Burton
2019-10-09 15:01 ` Luiz Augusto von Dentz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABBYNZJCwvSRL_AotOSaiEwSg7=8ZCUC=wEvrmtQrh9BUQ+pGQ@mail.gmail.com' \
--to=luiz.dentz@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).