Re: [PATCH 09/10] Bluetooth: btusb: Add support for ISO packets

[Luiz Augusto von Dentz <luiz.dentz@gmail.com>]

Hi Marcel,

On Wed, Jan 8, 2020 at 1:22 PM Marcel Holtmann <marcel@holtmann.org> wrote:
>
> Hi Luiz,
>
> > This enabled btusb driver to properly transmit ISO packets.
> >
> > Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> > ---
> > drivers/bluetooth/btusb.c | 14 ++++++++++++++
> > 1 file changed, 14 insertions(+)
> >
> > diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> > index f5924f3e8b8d..ded0ba83bcce 100644
> > --- a/drivers/bluetooth/btusb.c
> > +++ b/drivers/bluetooth/btusb.c
> > @@ -1463,6 +1463,13 @@ static int btusb_send_frame(struct hci_dev *hdev, struct sk_buff *skb)
> >
> >               hdev->stat.sco_tx++;
> >               return submit_tx_urb(hdev, urb);
> > +
> > +     case HCI_ISODATA_PKT:
> > +             urb = alloc_bulk_urb(hdev, skb);
> > +             if (IS_ERR(urb))
> > +                     return PTR_ERR(urb);
> > +
> > +             return submit_or_queue_tx_urb(hdev, urb);
> >       }
> >
> >       return -EILSEQ;
> > @@ -2123,6 +2130,13 @@ static int btusb_send_frame_intel(struct hci_dev *hdev, struct sk_buff *skb)
> >
> >               hdev->stat.sco_tx++;
> >               return submit_tx_urb(hdev, urb);
> > +
> > +     case HCI_ISODATA_PKT:
> > +             urb = alloc_bulk_urb(hdev, skb);
> > +             if (IS_ERR(urb))
> > +                     return PTR_ERR(urb);
> > +
> > +             return submit_or_queue_tx_urb(hdev, urb);
> >       }
>
> I am failing to see where it says to use bulk endpoints.

It doesn't, in fact USB don't seem to have anything for ISO so this is
the assumption we made that bulk would cut it, though I would agree an
ISOC endpoint would actually be better but afaik we would need new
alternate settings if we intend to use with the new ISO packets, so it
doesn't look like there is any other option to USB transport to just
sent packet over the bulk endpoint, or perhaps you want to file an
issue against the spec to specify this properly?

> Regards
>
> Marcel
>


-- 
Luiz Augusto von Dentz