* [PATCH BlueZ] Makefile.obexd: add missing mkdir in builtin.h generation
@ 2019-10-08 9:58 Ross Burton
2019-10-09 15:01 ` Luiz Augusto von Dentz
0 siblings, 1 reply; 2+ messages in thread
From: Ross Burton @ 2019-10-08 9:58 UTC (permalink / raw)
To: linux-bluetooth
In parallel out-of-tree builds it's possible that obexd/src/builtin.h is
generated before the target directory has been implicitly created. Solve this by
creating the directory before writing into it.
---
Makefile.obexd | 1 +
1 file changed, 1 insertion(+)
diff --git a/Makefile.obexd b/Makefile.obexd
index d36874770..de59d297b 100644
--- a/Makefile.obexd
+++ b/Makefile.obexd
@@ -104,6 +104,7 @@ BUILT_SOURCES += obexd/src/builtin.h
obexd/src/plugin.$(OBJEXT): obexd/src/builtin.h
obexd/src/builtin.h: obexd/src/genbuiltin $(obexd_builtin_sources)
+ $(AM_V_at)$(MKDIR_P) $(dir $@)
$(AM_V_GEN)$(srcdir)/obexd/src/genbuiltin $(obexd_builtin_modules) > $@
CLEANFILES += obexd/src/builtin.h $(builtin_files) obexd/src/obex.service
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH BlueZ] Makefile.obexd: add missing mkdir in builtin.h generation
2019-10-08 9:58 [PATCH BlueZ] Makefile.obexd: add missing mkdir in builtin.h generation Ross Burton
@ 2019-10-09 15:01 ` Luiz Augusto von Dentz
0 siblings, 0 replies; 2+ messages in thread
From: Luiz Augusto von Dentz @ 2019-10-09 15:01 UTC (permalink / raw)
To: Ross Burton; +Cc: linux-bluetooth
Hi Ross,
On Tue, Oct 8, 2019 at 1:03 PM Ross Burton <ross.burton@intel.com> wrote:
>
> In parallel out-of-tree builds it's possible that obexd/src/builtin.h is
> generated before the target directory has been implicitly created. Solve this by
> creating the directory before writing into it.
> ---
> Makefile.obexd | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Makefile.obexd b/Makefile.obexd
> index d36874770..de59d297b 100644
> --- a/Makefile.obexd
> +++ b/Makefile.obexd
> @@ -104,6 +104,7 @@ BUILT_SOURCES += obexd/src/builtin.h
> obexd/src/plugin.$(OBJEXT): obexd/src/builtin.h
>
> obexd/src/builtin.h: obexd/src/genbuiltin $(obexd_builtin_sources)
> + $(AM_V_at)$(MKDIR_P) $(dir $@)
> $(AM_V_GEN)$(srcdir)/obexd/src/genbuiltin $(obexd_builtin_modules) > $@
>
> CLEANFILES += obexd/src/builtin.h $(builtin_files) obexd/src/obex.service
> --
> 2.20.1
Applied, thanks.
--
Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-09 15:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-08 9:58 [PATCH BlueZ] Makefile.obexd: add missing mkdir in builtin.h generation Ross Burton
2019-10-09 15:01 ` Luiz Augusto von Dentz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).