From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: hofman.robbert@gmail.com
Cc: "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Subject: Re: Improving error messages in BlueZ
Date: Thu, 8 Nov 2018 16:45:04 +0200 [thread overview]
Message-ID: <CABBYNZKS_MCwdC1T+PChPEe8Qfswxoc3qocPZsfMVarEYF7nag@mail.gmail.com> (raw)
In-Reply-To: <CADZhEUBeTf0-muEdXg0f_-nq3udgj2ZiSzRgg68Yp8GRywmZeQ@mail.gmail.com>
Hi Robbert,
On Thu, Nov 8, 2018 at 3:34 PM Robbert Hofman <hofman.robbert@gmail.com> wrote:
>
> Hi,
>
> I am not familiar with the way pull requests work on git.kernel.org,
> so I'm trying to make my proposal via email. Excuse me if I'm doing
> something wrong here.
Did you check the HACKING documentation:
https://git.kernel.org/pub/scm/bluetooth/bluez.git/tree/HACKING#n95
> I wanted to improve the error messages that gatttool prints, a.o. when
> not specifying a value to write to a certain characteristic. See
> https://github.com/pauloborges/bluez/pull/8/commits/745e8308bacb0e60e39237c821b08960cf0aba55
> where I made a commit that would do so.
gatttool is a deprecated tool, you should be able to do the same using
bluetoothctl nowadays.
> When following the tutorial on how to make a pull request
> (https://www.kernel.org/doc/html/v4.17/maintainer/pull-requests.html),
> upon trying to push my commit to a new branch, I got an "access
> denied" error message from git. So I guess not everyone can just make
> a pull request? Can I get any help on how to make this work?
>
> Kind regards,
> Robbert
--
Luiz Augusto von Dentz
prev parent reply other threads:[~2018-11-08 14:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 13:27 Improving error messages in BlueZ Robbert Hofman
2018-11-08 14:45 ` Luiz Augusto von Dentz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABBYNZKS_MCwdC1T+PChPEe8Qfswxoc3qocPZsfMVarEYF7nag@mail.gmail.com \
--to=luiz.dentz@gmail.com \
--cc=hofman.robbert@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).