Linux-Bluetooth Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH BlueZ v2] main: add missing comma after AlwaysPairable
@ 2020-07-24 14:03 Michael Nosthoff
  2020-07-27 23:15 ` Luiz Augusto von Dentz
  0 siblings, 1 reply; 2+ messages in thread
From: Michael Nosthoff @ 2020-07-24 14:03 UTC (permalink / raw)
  To: linux-bluetooth; +Cc: Michael Nosthoff

Commit 1880b2990866 ("core: Add AlwaysPairable to main.conf") added a new
key to supported_options but didn't add a comma. This leads to the
following error message on startup if the key 'PairableTimeout' is pesent:

Unknown key PairableTimeout for group General in /etc/bluetooth/main.conf

This probably also leads to ignoring the setting.

Fixes: 1880b2990866 ("core: Add AlwaysPairable to main.conf")
---
 src/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/main.c b/src/main.c
index ec7a9fbd7..2c083de67 100644
--- a/src/main.c
+++ b/src/main.c
@@ -79,7 +79,7 @@ static const char *supported_options[] = {
 	"Name",
 	"Class",
 	"DiscoverableTimeout",
-	"AlwaysPairable"
+	"AlwaysPairable",
 	"PairableTimeout",
 	"DeviceID",
 	"ReverseServiceDiscovery",
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH BlueZ v2] main: add missing comma after AlwaysPairable
  2020-07-24 14:03 [PATCH BlueZ v2] main: add missing comma after AlwaysPairable Michael Nosthoff
@ 2020-07-27 23:15 ` Luiz Augusto von Dentz
  0 siblings, 0 replies; 2+ messages in thread
From: Luiz Augusto von Dentz @ 2020-07-27 23:15 UTC (permalink / raw)
  To: committed; +Cc: linux-bluetooth

Hi,

On Fri, Jul 24, 2020 at 7:08 AM Michael Nosthoff <committed@heine.so> wrote:
>
> Commit 1880b2990866 ("core: Add AlwaysPairable to main.conf") added a new
> key to supported_options but didn't add a comma. This leads to the
> following error message on startup if the key 'PairableTimeout' is pesent:
>
> Unknown key PairableTimeout for group General in /etc/bluetooth/main.conf
>
> This probably also leads to ignoring the setting.
>
> Fixes: 1880b2990866 ("core: Add AlwaysPairable to main.conf")
> ---
>  src/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/main.c b/src/main.c
> index ec7a9fbd7..2c083de67 100644
> --- a/src/main.c
> +++ b/src/main.c
> @@ -79,7 +79,7 @@ static const char *supported_options[] = {
>         "Name",
>         "Class",
>         "DiscoverableTimeout",
> -       "AlwaysPairable"
> +       "AlwaysPairable",
>         "PairableTimeout",
>         "DeviceID",
>         "ReverseServiceDiscovery",
> --
> 2.25.1

Applied, thanks.

-- 
Luiz Augusto von Dentz

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-24 14:03 [PATCH BlueZ v2] main: add missing comma after AlwaysPairable Michael Nosthoff
2020-07-27 23:15 ` Luiz Augusto von Dentz

Linux-Bluetooth Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-bluetooth/0 linux-bluetooth/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-bluetooth linux-bluetooth/ https://lore.kernel.org/linux-bluetooth \
		linux-bluetooth@vger.kernel.org
	public-inbox-index linux-bluetooth

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-bluetooth


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git