* [BlueZ PATCH v1] lib: Correct the name of Add Advertisement Patterns Monitor Command opcode
@ 2020-06-16 4:28 Miao-chen Chou
2020-06-16 4:36 ` [BlueZ,v1] " bluez.test.bot
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Miao-chen Chou @ 2020-06-16 4:28 UTC (permalink / raw)
To: Bluetooth Kernel Mailing List
Cc: Alain Michaud, Luiz Augusto von Dentz, Marcel Holtmann, Miao-chen Chou
lib/mgmt.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/mgmt.h b/lib/mgmt.h
index f44f2465d..bb31156ab 100644
--- a/lib/mgmt.h
+++ b/lib/mgmt.h
@@ -673,7 +673,7 @@ struct mgmt_adv_pattern {
uint8_t value[31];
} __packed;
-#define MGMT_OP_ADD_ADV_MONITOR 0x0052
+#define MGMT_OP_ADD_ADV_PATTERNS_MONITOR 0x0052
struct mgmt_cp_add_adv_monitor {
uint8_t pattern_count;
struct mgmt_adv_pattern patterns[0];
--
2.26.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* RE: [BlueZ,v1] lib: Correct the name of Add Advertisement Patterns Monitor Command opcode
2020-06-16 4:28 [BlueZ PATCH v1] lib: Correct the name of Add Advertisement Patterns Monitor Command opcode Miao-chen Chou
@ 2020-06-16 4:36 ` bluez.test.bot
2020-06-16 6:14 ` [BlueZ PATCH v1] " Von Dentz, Luiz
2020-06-16 17:27 ` Luiz Augusto von Dentz
2 siblings, 0 replies; 5+ messages in thread
From: bluez.test.bot @ 2020-06-16 4:36 UTC (permalink / raw)
To: linux-bluetooth, mcchou
[-- Attachment #1: Type: text/plain, Size: 437 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
While we are preparing for reviewing the patches, we found the following
issue/warning.
Test Result:
checkgitlint Failed
Outputs:
1: T1 Title exceeds max length (74>72): "lib: Correct the name of Add Advertisement Patterns Monitor Command opcode"
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [BlueZ PATCH v1] lib: Correct the name of Add Advertisement Patterns Monitor Command opcode
2020-06-16 4:28 [BlueZ PATCH v1] lib: Correct the name of Add Advertisement Patterns Monitor Command opcode Miao-chen Chou
2020-06-16 4:36 ` [BlueZ,v1] " bluez.test.bot
@ 2020-06-16 6:14 ` Von Dentz, Luiz
2020-06-16 6:38 ` Luiz Augusto von Dentz
2020-06-16 17:27 ` Luiz Augusto von Dentz
2 siblings, 1 reply; 5+ messages in thread
From: Von Dentz, Luiz @ 2020-06-16 6:14 UTC (permalink / raw)
To: Miao-chen Chou
Cc: Bluetooth Kernel Mailing List, Alain Michaud, Marcel Holtmann
Hi Miao,
On Mon, Jun 15, 2020 at 9:28 PM Miao-chen Chou <mcchou@chromium.org> wrote:
>
> lib/mgmt.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/mgmt.h b/lib/mgmt.h
> index f44f2465d..bb31156ab 100644
> --- a/lib/mgmt.h
> +++ b/lib/mgmt.h
> @@ -673,7 +673,7 @@ struct mgmt_adv_pattern {
> uint8_t value[31];
> } __packed;
>
> -#define MGMT_OP_ADD_ADV_MONITOR 0x0052
> +#define MGMT_OP_ADD_ADV_PATTERNS_MONITOR 0x0052
> struct mgmt_cp_add_adv_monitor {
> uint8_t pattern_count;
> struct mgmt_adv_pattern patterns[0];
> --
> 2.26.2
The name already contains PATTERNS:
https://git.kernel.org/pub/scm/bluetooth/bluez.git/tree/doc/mgmt-api.txt#n3499
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [BlueZ PATCH v1] lib: Correct the name of Add Advertisement Patterns Monitor Command opcode
2020-06-16 6:14 ` [BlueZ PATCH v1] " Von Dentz, Luiz
@ 2020-06-16 6:38 ` Luiz Augusto von Dentz
0 siblings, 0 replies; 5+ messages in thread
From: Luiz Augusto von Dentz @ 2020-06-16 6:38 UTC (permalink / raw)
To: Von Dentz, Luiz
Cc: Miao-chen Chou, Bluetooth Kernel Mailing List, Alain Michaud,
Marcel Holtmann
On Mon, Jun 15, 2020 at 11:18 PM Von Dentz, Luiz
<luiz.von.dentz@intel.com> wrote:
>
> Hi Miao,
>
> On Mon, Jun 15, 2020 at 9:28 PM Miao-chen Chou <mcchou@chromium.org> wrote:
> >
> > lib/mgmt.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/mgmt.h b/lib/mgmt.h
> > index f44f2465d..bb31156ab 100644
> > --- a/lib/mgmt.h
> > +++ b/lib/mgmt.h
> > @@ -673,7 +673,7 @@ struct mgmt_adv_pattern {
> > uint8_t value[31];
> > } __packed;
> >
> > -#define MGMT_OP_ADD_ADV_MONITOR 0x0052
> > +#define MGMT_OP_ADD_ADV_PATTERNS_MONITOR 0x0052
> > struct mgmt_cp_add_adv_monitor {
> > uint8_t pattern_count;
> > struct mgmt_adv_pattern patterns[0];
> > --
> > 2.26.2
>
>
> The name already contains PATTERNS:
>
> https://git.kernel.org/pub/scm/bluetooth/bluez.git/tree/doc/mgmt-api.txt#n3499
Nevermind this is actually the command name rather than its definition
which is what you are fixing.
--
Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [BlueZ PATCH v1] lib: Correct the name of Add Advertisement Patterns Monitor Command opcode
2020-06-16 4:28 [BlueZ PATCH v1] lib: Correct the name of Add Advertisement Patterns Monitor Command opcode Miao-chen Chou
2020-06-16 4:36 ` [BlueZ,v1] " bluez.test.bot
2020-06-16 6:14 ` [BlueZ PATCH v1] " Von Dentz, Luiz
@ 2020-06-16 17:27 ` Luiz Augusto von Dentz
2 siblings, 0 replies; 5+ messages in thread
From: Luiz Augusto von Dentz @ 2020-06-16 17:27 UTC (permalink / raw)
To: Miao-chen Chou
Cc: Bluetooth Kernel Mailing List, Alain Michaud,
Luiz Augusto von Dentz, Marcel Holtmann
Hi Miao,
On Mon, Jun 15, 2020 at 9:32 PM Miao-chen Chou <mcchou@chromium.org> wrote:
>
> lib/mgmt.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/mgmt.h b/lib/mgmt.h
> index f44f2465d..bb31156ab 100644
> --- a/lib/mgmt.h
> +++ b/lib/mgmt.h
> @@ -673,7 +673,7 @@ struct mgmt_adv_pattern {
> uint8_t value[31];
> } __packed;
>
> -#define MGMT_OP_ADD_ADV_MONITOR 0x0052
> +#define MGMT_OP_ADD_ADV_PATTERNS_MONITOR 0x0052
> struct mgmt_cp_add_adv_monitor {
> uint8_t pattern_count;
> struct mgmt_adv_pattern patterns[0];
> --
> 2.26.2
>
Applied, thanks.
--
Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-06-16 17:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-16 4:28 [BlueZ PATCH v1] lib: Correct the name of Add Advertisement Patterns Monitor Command opcode Miao-chen Chou
2020-06-16 4:36 ` [BlueZ,v1] " bluez.test.bot
2020-06-16 6:14 ` [BlueZ PATCH v1] " Von Dentz, Luiz
2020-06-16 6:38 ` Luiz Augusto von Dentz
2020-06-16 17:27 ` Luiz Augusto von Dentz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).