linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v1] Bluetooth: Add a new MGMT error code for 0x3E HCI error
@ 2021-04-29 17:38 Yu Liu
  2021-05-01  2:16 ` [v1] " bluez.test.bot
  2021-05-05 16:07 ` [PATCH v1] " Yu Liu
  0 siblings, 2 replies; 3+ messages in thread
From: Yu Liu @ 2021-04-29 17:38 UTC (permalink / raw)
  To: linux-bluetooth, marcel, chromeos-bluetooth-upstreaming
  Cc: Yu Liu, Abhishek Pandit-Subedi, David S. Miller, Jakub Kicinski,
	Johan Hedberg, Luiz Augusto von Dentz, linux-kernel, netdev

This is to enable us to retry the pairing in the user space if this
failure is encountered

Reviewed-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>

Signed-off-by: Yu Liu <yudiliu@google.com>
---

Changes in v1:
- Initial change

 include/net/bluetooth/mgmt.h | 1 +
 net/bluetooth/mgmt.c         | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/include/net/bluetooth/mgmt.h b/include/net/bluetooth/mgmt.h
index a03c62b1dc2f..78b94577a7d8 100644
--- a/include/net/bluetooth/mgmt.h
+++ b/include/net/bluetooth/mgmt.h
@@ -45,6 +45,7 @@
 #define MGMT_STATUS_RFKILLED		0x12
 #define MGMT_STATUS_ALREADY_PAIRED	0x13
 #define MGMT_STATUS_PERMISSION_DENIED	0x14
+#define MGMT_STATUS_CONNECT_NOT_ESTD	0x15
 
 struct mgmt_hdr {
 	__le16	opcode;
diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
index b44e19c69c44..9e44c04d4212 100644
--- a/net/bluetooth/mgmt.c
+++ b/net/bluetooth/mgmt.c
@@ -271,7 +271,7 @@ static const u8 mgmt_status_table[] = {
 	MGMT_STATUS_INVALID_PARAMS,	/* Unsuitable Connection Interval */
 	MGMT_STATUS_TIMEOUT,		/* Directed Advertising Timeout */
 	MGMT_STATUS_AUTH_FAILED,	/* Terminated Due to MIC Failure */
-	MGMT_STATUS_CONNECT_FAILED,	/* Connection Establishment Failed */
+	MGMT_STATUS_CONNECT_NOT_ESTD,	/* Connection Establishment Failed */
 	MGMT_STATUS_CONNECT_FAILED,	/* MAC Connection Failed */
 };
 
-- 
2.31.1.527.g47e6f16901-goog


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* RE: [v1] Bluetooth: Add a new MGMT error code for 0x3E HCI error
  2021-04-29 17:38 [PATCH v1] Bluetooth: Add a new MGMT error code for 0x3E HCI error Yu Liu
@ 2021-05-01  2:16 ` bluez.test.bot
  2021-05-05 16:07 ` [PATCH v1] " Yu Liu
  1 sibling, 0 replies; 3+ messages in thread
From: bluez.test.bot @ 2021-05-01  2:16 UTC (permalink / raw)
  To: linux-bluetooth, yudiliu

[-- Attachment #1: Type: text/plain, Size: 1468 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=475325

---Test result---

##############################
Test: CheckPatch - PASS


##############################
Test: CheckGitLint - PASS


##############################
Test: CheckBuildK - PASS


##############################
Test: CheckTestRunner: Setup - PASS


##############################
Test: CheckTestRunner: l2cap-tester - PASS
Total: 40, Passed: 40 (100.0%), Failed: 0, Not Run: 0

##############################
Test: CheckTestRunner: bnep-tester - PASS
Total: 1, Passed: 1 (100.0%), Failed: 0, Not Run: 0

##############################
Test: CheckTestRunner: mgmt-tester - PASS
Total: 416, Passed: 403 (96.9%), Failed: 0, Not Run: 13

##############################
Test: CheckTestRunner: rfcomm-tester - PASS
Total: 9, Passed: 9 (100.0%), Failed: 0, Not Run: 0

##############################
Test: CheckTestRunner: sco-tester - PASS
Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0

##############################
Test: CheckTestRunner: smp-tester - PASS
Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0

##############################
Test: CheckTestRunner: userchan-tester - PASS
Total: 3, Passed: 3 (100.0%), Failed: 0, Not Run: 0



---
Regards,
Linux Bluetooth


[-- Attachment #2: l2cap-tester.log --]
[-- Type: application/octet-stream, Size: 44233 bytes --]

[-- Attachment #3: bnep-tester.log --]
[-- Type: application/octet-stream, Size: 3559 bytes --]

[-- Attachment #4: mgmt-tester.log --]
[-- Type: application/octet-stream, Size: 546748 bytes --]

[-- Attachment #5: rfcomm-tester.log --]
[-- Type: application/octet-stream, Size: 11680 bytes --]

[-- Attachment #6: sco-tester.log --]
[-- Type: application/octet-stream, Size: 9915 bytes --]

[-- Attachment #7: smp-tester.log --]
[-- Type: application/octet-stream, Size: 11826 bytes --]

[-- Attachment #8: userchan-tester.log --]
[-- Type: application/octet-stream, Size: 5456 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v1] Bluetooth: Add a new MGMT error code for 0x3E HCI error
  2021-04-29 17:38 [PATCH v1] Bluetooth: Add a new MGMT error code for 0x3E HCI error Yu Liu
  2021-05-01  2:16 ` [v1] " bluez.test.bot
@ 2021-05-05 16:07 ` Yu Liu
  1 sibling, 0 replies; 3+ messages in thread
From: Yu Liu @ 2021-05-05 16:07 UTC (permalink / raw)
  To: linux-bluetooth, Marcel Holtmann; +Cc: Luiz Augusto von Dentz, linux-kernel

ping for attention.

On Thu, Apr 29, 2021 at 10:38 AM Yu Liu <yudiliu@google.com> wrote:
>
> This is to enable us to retry the pairing in the user space if this
> failure is encountered
>
> Reviewed-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
>
> Signed-off-by: Yu Liu <yudiliu@google.com>
> ---
>
> Changes in v1:
> - Initial change
>
>  include/net/bluetooth/mgmt.h | 1 +
>  net/bluetooth/mgmt.c         | 2 +-
>  2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/net/bluetooth/mgmt.h b/include/net/bluetooth/mgmt.h
> index a03c62b1dc2f..78b94577a7d8 100644
> --- a/include/net/bluetooth/mgmt.h
> +++ b/include/net/bluetooth/mgmt.h
> @@ -45,6 +45,7 @@
>  #define MGMT_STATUS_RFKILLED           0x12
>  #define MGMT_STATUS_ALREADY_PAIRED     0x13
>  #define MGMT_STATUS_PERMISSION_DENIED  0x14
> +#define MGMT_STATUS_CONNECT_NOT_ESTD   0x15
>
>  struct mgmt_hdr {
>         __le16  opcode;
> diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
> index b44e19c69c44..9e44c04d4212 100644
> --- a/net/bluetooth/mgmt.c
> +++ b/net/bluetooth/mgmt.c
> @@ -271,7 +271,7 @@ static const u8 mgmt_status_table[] = {
>         MGMT_STATUS_INVALID_PARAMS,     /* Unsuitable Connection Interval */
>         MGMT_STATUS_TIMEOUT,            /* Directed Advertising Timeout */
>         MGMT_STATUS_AUTH_FAILED,        /* Terminated Due to MIC Failure */
> -       MGMT_STATUS_CONNECT_FAILED,     /* Connection Establishment Failed */
> +       MGMT_STATUS_CONNECT_NOT_ESTD,   /* Connection Establishment Failed */
>         MGMT_STATUS_CONNECT_FAILED,     /* MAC Connection Failed */
>  };
>
> --
> 2.31.1.527.g47e6f16901-goog
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-05-05 16:07 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-29 17:38 [PATCH v1] Bluetooth: Add a new MGMT error code for 0x3E HCI error Yu Liu
2021-05-01  2:16 ` [v1] " bluez.test.bot
2021-05-05 16:07 ` [PATCH v1] " Yu Liu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).