* [PATCH] Bluetooth: btusb: Comment on unbalanced pm reference
@ 2020-06-25 23:26 Abhishek Pandit-Subedi
2020-06-26 4:26 ` Marcel Holtmann
0 siblings, 1 reply; 2+ messages in thread
From: Abhishek Pandit-Subedi @ 2020-06-25 23:26 UTC (permalink / raw)
To: marcel, Oliver Neukum, linux-bluetooth
Cc: chromeos-bluetooth-upstreaming, linux-pm, Abhishek Pandit-Subedi,
Johan Hedberg, linux-kernel
Add a comment clarifying that a PM reference in btusb_qca_cmd_timeout is
not unbalanced because it results in a device reset.
Signed-off-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
---
drivers/bluetooth/btusb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index f8a71fdabb3d1b..0e143c0cecf2a1 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -581,6 +581,7 @@ static void btusb_qca_cmd_timeout(struct hci_dev *hdev)
return;
bt_dev_err(hdev, "Multiple cmd timeouts seen. Resetting usb device.");
+ /* This is not an unbalanced PM reference since the device will reset */
err = usb_autopm_get_interface(data->intf);
if (!err)
usb_queue_reset_device(data->intf);
--
2.27.0.111.gc72c7da667-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Bluetooth: btusb: Comment on unbalanced pm reference
2020-06-25 23:26 [PATCH] Bluetooth: btusb: Comment on unbalanced pm reference Abhishek Pandit-Subedi
@ 2020-06-26 4:26 ` Marcel Holtmann
0 siblings, 0 replies; 2+ messages in thread
From: Marcel Holtmann @ 2020-06-26 4:26 UTC (permalink / raw)
To: Abhishek Pandit-Subedi
Cc: Oliver Neukum, BlueZ, ChromeOS Bluetooth Upstreaming, linux-pm,
Johan Hedberg, linux-kernel
Hi Abhishek,
> Add a comment clarifying that a PM reference in btusb_qca_cmd_timeout is
> not unbalanced because it results in a device reset.
>
> Signed-off-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
> ---
>
> drivers/bluetooth/btusb.c | 1 +
> 1 file changed, 1 insertion(+)
patch has been applied to bluetooth-next tree.
Regards
Marcel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-26 4:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-25 23:26 [PATCH] Bluetooth: btusb: Comment on unbalanced pm reference Abhishek Pandit-Subedi
2020-06-26 4:26 ` Marcel Holtmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).