* [PATCH -next] Bluetooth: L2CAP: remove set but not used variable 'credits'
@ 2020-03-14 10:06 YueHaibing
2020-03-14 18:50 ` Marcel Holtmann
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2020-03-14 10:06 UTC (permalink / raw)
To: marcel, johan.hedberg, davem, kuba, luiz.von.dentz
Cc: linux-bluetooth, netdev, linux-kernel, YueHaibing
net/bluetooth/l2cap_core.c: In function l2cap_ecred_conn_req:
net/bluetooth/l2cap_core.c:5848:6: warning: variable credits set but not used [-Wunused-but-set-variable]
commit 15f02b910562 ("Bluetooth: L2CAP: Add initial code for Enhanced Credit Based Mode")
involved this unused variable, remove it.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
net/bluetooth/l2cap_core.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
index 5e6e35ab44dd..8b0fca39989d 100644
--- a/net/bluetooth/l2cap_core.c
+++ b/net/bluetooth/l2cap_core.c
@@ -5845,7 +5845,7 @@ static inline int l2cap_ecred_conn_req(struct l2cap_conn *conn,
__le16 dcid[5];
} __packed pdu;
struct l2cap_chan *chan, *pchan;
- u16 credits, mtu, mps;
+ u16 mtu, mps;
__le16 psm;
u8 result, len = 0;
int i, num_scid;
@@ -5868,7 +5868,6 @@ static inline int l2cap_ecred_conn_req(struct l2cap_conn *conn,
}
psm = req->psm;
- credits = 0;
BT_DBG("psm 0x%2.2x mtu %u mps %u", __le16_to_cpu(psm), mtu, mps);
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] Bluetooth: L2CAP: remove set but not used variable 'credits'
2020-03-14 10:06 [PATCH -next] Bluetooth: L2CAP: remove set but not used variable 'credits' YueHaibing
@ 2020-03-14 18:50 ` Marcel Holtmann
0 siblings, 0 replies; 2+ messages in thread
From: Marcel Holtmann @ 2020-03-14 18:50 UTC (permalink / raw)
To: YueHaibing
Cc: Johan Hedberg, David S. Miller, kuba, Luiz Augusto von Dentz,
linux-bluetooth, netdev, linux-kernel
Hi Yue,
> net/bluetooth/l2cap_core.c: In function l2cap_ecred_conn_req:
> net/bluetooth/l2cap_core.c:5848:6: warning: variable credits set but not used [-Wunused-but-set-variable]
>
> commit 15f02b910562 ("Bluetooth: L2CAP: Add initial code for Enhanced Credit Based Mode")
> involved this unused variable, remove it.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> net/bluetooth/l2cap_core.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-15 1:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-14 10:06 [PATCH -next] Bluetooth: L2CAP: remove set but not used variable 'credits' YueHaibing
2020-03-14 18:50 ` Marcel Holtmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).