linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Bluetooth: hci_sync: Fix not setting adv set duration
@ 2021-11-01 22:14 Luiz Augusto von Dentz
  2021-11-02  7:16 ` Marcel Holtmann
  0 siblings, 1 reply; 2+ messages in thread
From: Luiz Augusto von Dentz @ 2021-11-01 22:14 UTC (permalink / raw)
  To: linux-bluetooth

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

10bbffa3e88e attempted to fix the use of rotation duration as
advertising duration but it didn't change the if condition which still
uses the duration instead of the timeout.

Fixes: 10bbffa3e88e ("Bluetooth: Fix using advertising instance duration as timeout")
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
---
 net/bluetooth/hci_sync.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c
index fb7ecf24b89a..b794605dc882 100644
--- a/net/bluetooth/hci_sync.c
+++ b/net/bluetooth/hci_sync.c
@@ -895,7 +895,7 @@ int hci_enable_ext_advertising_sync(struct hci_dev *hdev, u8 instance)
 	/* Set duration per instance since controller is responsible for
 	 * scheduling it.
 	 */
-	if (adv && adv->duration) {
+	if (adv && adv->timeout) {
 		u16 duration = adv->timeout * MSEC_PER_SEC;
 
 		/* Time = N * 10 ms */
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Bluetooth: hci_sync: Fix not setting adv set duration
  2021-11-01 22:14 [PATCH] Bluetooth: hci_sync: Fix not setting adv set duration Luiz Augusto von Dentz
@ 2021-11-02  7:16 ` Marcel Holtmann
  0 siblings, 0 replies; 2+ messages in thread
From: Marcel Holtmann @ 2021-11-02  7:16 UTC (permalink / raw)
  To: Luiz Augusto von Dentz; +Cc: linux-bluetooth

Hi Luiz,

> 10bbffa3e88e attempted to fix the use of rotation duration as
> advertising duration but it didn't change the if condition which still
> uses the duration instead of the timeout.
> 
> Fixes: 10bbffa3e88e ("Bluetooth: Fix using advertising instance duration as timeout")
> Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> ---
> net/bluetooth/hci_sync.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-11-02  7:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-01 22:14 [PATCH] Bluetooth: hci_sync: Fix not setting adv set duration Luiz Augusto von Dentz
2021-11-02  7:16 ` Marcel Holtmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).