From: Marcel Holtmann <marcel@holtmann.org>
To: YueHaibing <yuehaibing@huawei.com>
Cc: Johan Hedberg <johan.hedberg@gmail.com>,
BlueZ devel list <linux-bluetooth@vger.kernel.org>,
kernel-janitors@vger.kernel.org, Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH -next] Bluetooth: hci_qca: Remove set but not used variable 'opcode'
Date: Wed, 8 Jan 2020 21:48:09 +0100 [thread overview]
Message-ID: <ED15472A-FD5F-4D10-90F3-E6932CA28BA7@holtmann.org> (raw)
In-Reply-To: <20200108015431.51996-1-yuehaibing@huawei.com>
Hi Yue,
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/bluetooth/hci_qca.c: In function 'qca_controller_memdump':
> drivers/bluetooth/hci_qca.c:980:6: warning:
> variable 'opcode' set but not used [-Wunused-but-set-variable]
>
> It is never used since commit d841502c79e3 ("Bluetooth: hci_qca: Collect
> controller memory dump during SSR"), so remove it.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/bluetooth/hci_qca.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
prev parent reply other threads:[~2020-01-08 20:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-08 1:54 [PATCH -next] Bluetooth: hci_qca: Remove set but not used variable 'opcode' YueHaibing
2020-01-08 20:48 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ED15472A-FD5F-4D10-90F3-E6932CA28BA7@holtmann.org \
--to=marcel@holtmann.org \
--cc=hulkci@huawei.com \
--cc=johan.hedberg@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).