linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH BlueZ 1/1] mesh: Use correct net_id for received CTL messages
       [not found] <20220630072919.20890-1-isak.westin@hotmail.com>
@ 2022-06-30  7:29 ` Isak Westin
  2022-06-30  8:36   ` mesh: Use correct net_id in ctl_received bluez.test.bot
  0 siblings, 1 reply; 3+ messages in thread
From: Isak Westin @ 2022-06-30  7:29 UTC (permalink / raw)
  To: linux-bluetooth; +Cc: Isak Westin

For received CTL mesh messages, the wrong network ID variable was
passed to ctl_received. This patch changes to the correct variable.

Also, changed type of net_key_id argument in ctl_received function
to be consistent wich the whole call chain.
---
 mesh/net.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mesh/net.c b/mesh/net.c
index 8ff3ef32e..e8e6d3a61 100644
--- a/mesh/net.c
+++ b/mesh/net.c
@@ -2028,7 +2028,7 @@ static bool seg_rxed(struct mesh_net *net, bool frnd, uint32_t iv_index,
 	return false;
 }
 
-static bool ctl_received(struct mesh_net *net, uint16_t net_key_id,
+static bool ctl_received(struct mesh_net *net, uint32_t net_key_id,
 						uint32_t iv_index, uint8_t ttl,
 						uint32_t seq,
 						uint16_t src, uint16_t dst,
@@ -2347,7 +2347,7 @@ static enum _relay_advice packet_received(void *user_data,
 							net_seqZero,
 							l_get_be32(msg + 3));
 			} else {
-				ctl_received(net, key_aid, iv_index, net_ttl,
+				ctl_received(net, net_key_id, iv_index, net_ttl,
 						net_seq, net_src, net_dst,
 						net_opcode, rssi, msg,
 								app_msg_len);
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* RE: mesh: Use correct net_id in ctl_received
  2022-06-30  7:29 ` [PATCH BlueZ 1/1] mesh: Use correct net_id for received CTL messages Isak Westin
@ 2022-06-30  8:36   ` bluez.test.bot
  0 siblings, 0 replies; 3+ messages in thread
From: bluez.test.bot @ 2022-06-30  8:36 UTC (permalink / raw)
  To: linux-bluetooth, isak.westin

[-- Attachment #1: Type: text/plain, Size: 995 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=655288

---Test result---

Test Summary:
CheckPatch                    PASS      1.47 seconds
GitLint                       PASS      1.07 seconds
Prep - Setup ELL              PASS      42.45 seconds
Build - Prep                  PASS      0.67 seconds
Build - Configure             PASS      8.46 seconds
Build - Make                  PASS      1263.52 seconds
Make Check                    PASS      11.28 seconds
Make Check w/Valgrind         PASS      442.87 seconds
Make Distcheck                PASS      220.49 seconds
Build w/ext ELL - Configure   PASS      8.13 seconds
Build w/ext ELL - Make        PASS      1219.91 seconds
Incremental Build with patchesPASS      0.00 seconds



---
Regards,
Linux Bluetooth


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH BlueZ 1/1] mesh: Use correct net_id for received CTL messages
       [not found] <20220415164335.24808-1-isak.westin@hotmail.com>
@ 2022-04-15 16:43 ` Isak Westin
  0 siblings, 0 replies; 3+ messages in thread
From: Isak Westin @ 2022-04-15 16:43 UTC (permalink / raw)
  To: linux-bluetooth; +Cc: Isak Westin

For received CTL mesh messages, the wrong network ID variable was
passed to ctl_received. This patch changes to the correct variable.

Also, changed type of net_key_id argument in ctl_received function
to be consistent wich the whole call chain.
---
 mesh/net.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mesh/net.c b/mesh/net.c
index 8ff3ef32e..e8e6d3a61 100644
--- a/mesh/net.c
+++ b/mesh/net.c
@@ -2028,7 +2028,7 @@ static bool seg_rxed(struct mesh_net *net, bool frnd, uint32_t iv_index,
 	return false;
 }
 
-static bool ctl_received(struct mesh_net *net, uint16_t net_key_id,
+static bool ctl_received(struct mesh_net *net, uint32_t net_key_id,
 						uint32_t iv_index, uint8_t ttl,
 						uint32_t seq,
 						uint16_t src, uint16_t dst,
@@ -2347,7 +2347,7 @@ static enum _relay_advice packet_received(void *user_data,
 							net_seqZero,
 							l_get_be32(msg + 3));
 			} else {
-				ctl_received(net, key_aid, iv_index, net_ttl,
+				ctl_received(net, net_key_id, iv_index, net_ttl,
 						net_seq, net_src, net_dst,
 						net_opcode, rssi, msg,
 								app_msg_len);
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-06-30  8:37 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20220630072919.20890-1-isak.westin@hotmail.com>
2022-06-30  7:29 ` [PATCH BlueZ 1/1] mesh: Use correct net_id for received CTL messages Isak Westin
2022-06-30  8:36   ` mesh: Use correct net_id in ctl_received bluez.test.bot
     [not found] <20220415164335.24808-1-isak.westin@hotmail.com>
2022-04-15 16:43 ` [PATCH BlueZ 1/1] mesh: Use correct net_id for received CTL messages Isak Westin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).