* [PATCH 1/1] mesh: Fix provisioning agent method call failure
[not found] <CGME20200122121618epcas5p1c87cda317c786f71497ad61237843227@epcas5p1.samsung.com>
@ 2020-01-22 12:16 ` Shaunak Soman
2020-01-23 15:40 ` Gix, Brian
0 siblings, 1 reply; 2+ messages in thread
From: Shaunak Soman @ 2020-01-22 12:16 UTC (permalink / raw)
To: linux-bluetooth
Provisioning agent interface methods PublicKey, PrivateKey and
Cancel do not accept any parameters. So, while invoking them
explicitly set the parameters to "".
---
mesh/agent.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/mesh/agent.c b/mesh/agent.c
index 9f9399f..3ab3893 100644
--- a/mesh/agent.c
+++ b/mesh/agent.c
@@ -515,6 +515,8 @@ static int request_key(struct mesh_agent *agent,
MESH_PROVISION_AGENT_INTERFACE,
method_name);
+ l_dbus_message_set_arguments(msg, "");
+
l_debug("Send key request to %s %s", agent->owner, agent->path);
l_dbus_send_with_reply(dbus_get_bus(), msg, key_reply, agent, NULL);
@@ -649,5 +651,8 @@ void mesh_agent_cancel(struct mesh_agent *agent)
msg = l_dbus_message_new_method_call(dbus, agent->owner, agent->path,
MESH_PROVISION_AGENT_INTERFACE,
"Cancel");
+
+ l_dbus_message_set_arguments(msg, "");
+
l_dbus_send(dbus, msg);
}
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] mesh: Fix provisioning agent method call failure
2020-01-22 12:16 ` [PATCH 1/1] mesh: Fix provisioning agent method call failure Shaunak Soman
@ 2020-01-23 15:40 ` Gix, Brian
0 siblings, 0 replies; 2+ messages in thread
From: Gix, Brian @ 2020-01-23 15:40 UTC (permalink / raw)
To: shaunak.01, linux-bluetooth
Applied
On Wed, 2020-01-22 at 17:46 +0530, Shaunak Soman wrote:
> Provisioning agent interface methods PublicKey, PrivateKey and
> Cancel do not accept any parameters. So, while invoking them
> explicitly set the parameters to "".
> ---
> mesh/agent.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/mesh/agent.c b/mesh/agent.c
> index 9f9399f..3ab3893 100644
> --- a/mesh/agent.c
> +++ b/mesh/agent.c
> @@ -515,6 +515,8 @@ static int request_key(struct mesh_agent *agent,
> MESH_PROVISION_AGENT_INTERFACE,
> method_name);
>
> + l_dbus_message_set_arguments(msg, "");
> +
> l_debug("Send key request to %s %s", agent->owner, agent->path);
>
> l_dbus_send_with_reply(dbus_get_bus(), msg, key_reply, agent, NULL);
> @@ -649,5 +651,8 @@ void mesh_agent_cancel(struct mesh_agent *agent)
> msg = l_dbus_message_new_method_call(dbus, agent->owner, agent->path,
> MESH_PROVISION_AGENT_INTERFACE,
> "Cancel");
> +
> + l_dbus_message_set_arguments(msg, "");
> +
> l_dbus_send(dbus, msg);
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-23 15:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20200122121618epcas5p1c87cda317c786f71497ad61237843227@epcas5p1.samsung.com>
2020-01-22 12:16 ` [PATCH 1/1] mesh: Fix provisioning agent method call failure Shaunak Soman
2020-01-23 15:40 ` Gix, Brian
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).