* [PATCH BlueZ] avrcp: Handle not implemented response to AVRCP_LIST_PLAYER_ATTRIBUTES
@ 2020-05-07 21:03 Luiz Augusto von Dentz
2020-05-07 23:51 ` Andrey Semashev
0 siblings, 1 reply; 2+ messages in thread
From: Luiz Augusto von Dentz @ 2020-05-07 21:03 UTC (permalink / raw)
To: linux-bluetooth
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
If remote device respond with ctype set to not implement don't continue
parsing the packet.
---
profiles/audio/avrcp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/profiles/audio/avrcp.c b/profiles/audio/avrcp.c
index 6b3f685d2..773ccdb60 100644
--- a/profiles/audio/avrcp.c
+++ b/profiles/audio/avrcp.c
@@ -2223,7 +2223,7 @@ static gboolean avrcp_list_player_attributes_rsp(struct avctp *conn,
uint8_t len, count = 0;
int i;
- if (code == AVC_CTYPE_REJECTED)
+ if (code == AVC_CTYPE_REJECTED || code == AVC_CTYPE_NOT_IMPLEMENTED)
return FALSE;
len = pdu->params[0];
--
2.25.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH BlueZ] avrcp: Handle not implemented response to AVRCP_LIST_PLAYER_ATTRIBUTES
2020-05-07 21:03 [PATCH BlueZ] avrcp: Handle not implemented response to AVRCP_LIST_PLAYER_ATTRIBUTES Luiz Augusto von Dentz
@ 2020-05-07 23:51 ` Andrey Semashev
0 siblings, 0 replies; 2+ messages in thread
From: Andrey Semashev @ 2020-05-07 23:51 UTC (permalink / raw)
To: Luiz Augusto von Dentz, linux-bluetooth
I think this patch is correct, but unfortunately, it doesn't solve the
problem with the Sennheiser MTW2 reboot.
On 2020-05-08 00:03, Luiz Augusto von Dentz wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
>
> If remote device respond with ctype set to not implement don't continue
> parsing the packet.
> ---
> profiles/audio/avrcp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/profiles/audio/avrcp.c b/profiles/audio/avrcp.c
> index 6b3f685d2..773ccdb60 100644
> --- a/profiles/audio/avrcp.c
> +++ b/profiles/audio/avrcp.c
> @@ -2223,7 +2223,7 @@ static gboolean avrcp_list_player_attributes_rsp(struct avctp *conn,
> uint8_t len, count = 0;
> int i;
>
> - if (code == AVC_CTYPE_REJECTED)
> + if (code == AVC_CTYPE_REJECTED || code == AVC_CTYPE_NOT_IMPLEMENTED)
> return FALSE;
>
> len = pdu->params[0];
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-07 23:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-07 21:03 [PATCH BlueZ] avrcp: Handle not implemented response to AVRCP_LIST_PLAYER_ATTRIBUTES Luiz Augusto von Dentz
2020-05-07 23:51 ` Andrey Semashev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).