* btrfs may be broken too - Re: Is ext4_dio_read_iter() broken?
[not found] ` <969260.1584004779@warthog.procyon.org.uk>
@ 2020-03-12 10:26 ` David Howells
0 siblings, 0 replies; only message in thread
From: David Howells @ 2020-03-12 10:26 UTC (permalink / raw)
To: clm, josef, dsterba
Cc: dhowells, mbobrowski, darrick.wong, jack, hch, linux-ext4,
linux-xfs, linux-btrfs, linux-fsdevel
David Howells <dhowells@redhat.com> wrote:
> > Is ext4_dio_read_iter() broken? It calls:
> >
> > file_accessed(iocb->ki_filp);
> >
> > at the end of the function - but surely iocb should be expected to have been
> > freed when iocb->ki_complete() was called?
>
> I think it's actually worse than that. You also can't call
> inode_unlock_shared(inode) because you no longer own a ref on the inode since
> ->ki_complete() is expected to call fput() on iocb->ki_filp.
>
> Yes, you own a shared lock on it, but unless somewhere along the
> fput-dput-iput chain the inode lock is taken exclusively, the inode can be
> freed whilst you're still holding the lock.
>
> Oh - and ext4_dax_read_iter() is also similarly broken.
>
> And xfs_file_dio_aio_read() appears to be broken as it touches the inode after
> calling iomap_dio_rw() to unlock it.
Seems btrfs_file_write_iter() is also broken:
if (iocb->ki_flags & IOCB_DIRECT) {
num_written = __btrfs_direct_write(iocb, from);
} else {
num_written = btrfs_buffered_write(iocb, from);
if (num_written > 0)
iocb->ki_pos = pos + num_written;
if (clean_page)
pagecache_isize_extended(inode, oldsize,
i_size_read(inode));
}
inode_unlock(inode);
But if __btrfs_direct_write() returned -EIOCBQUEUED then inode may have been
deallocated by the point it's calling inode_unlock(). Holding the lock is not
a preventative measure that I can see.
David
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-03-12 10:26 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1015227.1584007677@warthog.procyon.org.uk>
[not found] ` <969260.1584004779@warthog.procyon.org.uk>
2020-03-12 10:26 ` btrfs may be broken too - Re: Is ext4_dio_read_iter() broken? David Howells
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).