From: Goffredo Baroncelli <kreijack@inwind.it>
To: dsterba@suse.cz, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/4] btrfs: add ioctl BTRFS_IOC_DEV_PROPERTIES.
Date: Tue, 23 Feb 2021 19:01:33 +0100 [thread overview]
Message-ID: <11613dcb-2819-5a64-773a-355eb110cd54@inwind.it> (raw)
In-Reply-To: <73fa4d2c-2593-5db2-c9b2-3adb34fb51b4@libero.it>
I resend it because I made a little mess with the quotation
On 2/23/21 6:59 PM, Goffredo Baroncelli wrote:
> On 2/23/21 2:53 PM, David Sterba wrote:
>> On Mon, Feb 22, 2021 at 10:19:06PM +0100, Goffredo Baroncelli wrote:
>>> From: Goffredo Baroncelli <kreijack@inwind.it>
>>>
>>> This ioctl is a base for returning / setting information from / to the
>>> fields of the btrfs_dev_item object.
>
Hi David,
>
>>
>> Please don't add a new ioctl for properties, they're using the xattr as
>> interface alrady.
How it is supposed to work with a device ?
I have to point out that the property is already exported in sysfs.
However I read a comment in sysfs code that discourages
to make a filesystem updating (open a new transaction) in the sysfs
handler. Do you have any suggestion ?
>
> Thanks in advance
> BR
> Goffredo
>
--
gpg @keyserver.linux.it: Goffredo Baroncelli <kreijackATinwind.it>
Key fingerprint BBF5 1610 0B64 DAC6 5F7D 17B2 0EDA 9B37 8B82 E0B5
next prev parent reply other threads:[~2021-02-23 18:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1614028083.git.kreijack@inwind.it>
2021-02-22 21:19 ` [PATCH 1/4] btrfs: add ioctl BTRFS_IOC_DEV_PROPERTIES Goffredo Baroncelli
2021-02-23 4:28 ` kernel test robot
2021-02-23 18:03 ` Goffredo Baroncelli
2021-02-23 13:53 ` David Sterba
2021-02-23 17:59 ` Goffredo Baroncelli
2021-02-23 18:01 ` Goffredo Baroncelli [this message]
2021-02-24 2:27 ` Anand Jain
2021-02-27 15:52 ` Zygo Blaxell
2021-02-27 15:58 ` Zygo Blaxell
2021-02-22 21:19 ` [PATCH 2/4] btrfs: add flags to give an hint to the chunk allocator Goffredo Baroncelli
2021-02-22 21:19 ` [PATCH 3/4] btrfs: export dev_item.type in /sys/fs/btrfs/<uuid>/devinfo/<devid>/type Goffredo Baroncelli
2021-02-22 21:19 ` [PATCH 4/4] btrfs: add allocator_hint mode Goffredo Baroncelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11613dcb-2819-5a64-773a-355eb110cd54@inwind.it \
--to=kreijack@inwind.it \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).