From: Anand Jain <anand.jain@oracle.com>
To: dsterba@suse.cz, Goffredo Baroncelli <kreijack@libero.it>,
linux-btrfs@vger.kernel.org,
Goffredo Baroncelli <kreijack@inwind.it>
Subject: Re: [PATCH 1/4] btrfs: add ioctl BTRFS_IOC_DEV_PROPERTIES.
Date: Wed, 24 Feb 2021 10:27:45 +0800 [thread overview]
Message-ID: <e60ed8a6-833c-77ed-f5a0-b069680b2cab@oracle.com> (raw)
In-Reply-To: <20210223135330.GU1993@twin.jikos.cz>
On 23/02/2021 21:53, David Sterba wrote:
> On Mon, Feb 22, 2021 at 10:19:06PM +0100, Goffredo Baroncelli wrote:
>> From: Goffredo Baroncelli <kreijack@inwind.it>
>>
>> This ioctl is a base for returning / setting information from / to the
>> fields of the btrfs_dev_item object.
>
> Please don't add a new ioctl for properties, they're using the xattr as
> interface alrady.
>
IMO a feature like this can be in memory only initially[1]. And later
when this feature is stable, add its on-disk.
[1]
https://patchwork.kernel.org/project/linux-btrfs/patch/0ed770d6d5e37fc942f3034d917d2b38477d7d20.1613668002.git.anand.jain@oracle.com/
Thanks, Anand
next prev parent reply other threads:[~2021-02-24 2:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1614028083.git.kreijack@inwind.it>
2021-02-22 21:19 ` [PATCH 1/4] btrfs: add ioctl BTRFS_IOC_DEV_PROPERTIES Goffredo Baroncelli
2021-02-23 4:28 ` kernel test robot
2021-02-23 18:03 ` Goffredo Baroncelli
2021-02-23 13:53 ` David Sterba
2021-02-23 17:59 ` Goffredo Baroncelli
2021-02-23 18:01 ` Goffredo Baroncelli
2021-02-24 2:27 ` Anand Jain [this message]
2021-02-27 15:52 ` Zygo Blaxell
2021-02-27 15:58 ` Zygo Blaxell
2021-02-22 21:19 ` [PATCH 2/4] btrfs: add flags to give an hint to the chunk allocator Goffredo Baroncelli
2021-02-22 21:19 ` [PATCH 3/4] btrfs: export dev_item.type in /sys/fs/btrfs/<uuid>/devinfo/<devid>/type Goffredo Baroncelli
2021-02-22 21:19 ` [PATCH 4/4] btrfs: add allocator_hint mode Goffredo Baroncelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e60ed8a6-833c-77ed-f5a0-b069680b2cab@oracle.com \
--to=anand.jain@oracle.com \
--cc=dsterba@suse.cz \
--cc=kreijack@inwind.it \
--cc=kreijack@libero.it \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).