linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Btrgs-progs: Define _GNU_SOURCE for strndup
@ 2010-06-28 16:55 Frederic Weisbecker
  2010-06-28 16:55 ` [PATCH] Btrfs-progs: Handle bad extent type case Frederic Weisbecker
  0 siblings, 1 reply; 2+ messages in thread
From: Frederic Weisbecker @ 2010-06-28 16:55 UTC (permalink / raw)
  To: Chris Mason; +Cc: The development of BTRFS, Frederic Weisbecker

This fixes:

btrfs-list.c: Dans la fonction =C2=ABino_resolve=C2=BB :
btrfs-list.c:511: attention : d=C3=A9claration implicite de la fonction=
 =C2=AB =C2=ABstrndup=C2=BB =C2=BB
btrfs-list.c:511: attention : incompatible implicit declaration of buil=
t-in function =C2=ABstrndup=C2=BB
make: *** [btrfs-list.o] Erreur 1

and:

btrfs.c: Dans la fonction =C2=ABsplit_command=C2=BB :
btrfs.c:168: attention : d=C3=A9claration implicite de la fonction =C2=AB=
 =C2=ABstrndup=C2=BB =C2=BB
btrfs.c:168: attention : incompatible implicit declaration of built-in =
function =C2=ABstrndup=C2=BB
make: *** [btrfs.o] Erreur 1

Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
---
 btrfs-list.c |    1 +
 btrfs.c      |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/btrfs-list.c b/btrfs-list.c
index 7741705..9dedb5d 100644
--- a/btrfs-list.c
+++ b/btrfs-list.c
@@ -16,6 +16,7 @@
  * Boston, MA 021110-1307, USA.
  */
=20
+#define _GNU_SOURCE
 #ifndef __CHECKER__
 #include <sys/ioctl.h>
 #include <sys/mount.h>
diff --git a/btrfs.c b/btrfs.c
index ab5e57f..672ffe2 100644
--- a/btrfs.c
+++ b/btrfs.c
@@ -15,6 +15,7 @@
  */
=20
=20
+#define _GNU_SOURCE
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
--=20
1.5.4.3

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" =
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] Btrfs-progs: Handle bad extent type case
  2010-06-28 16:55 [PATCH] Btrgs-progs: Define _GNU_SOURCE for strndup Frederic Weisbecker
@ 2010-06-28 16:55 ` Frederic Weisbecker
  0 siblings, 0 replies; 2+ messages in thread
From: Frederic Weisbecker @ 2010-06-28 16:55 UTC (permalink / raw)
  To: Chris Mason; +Cc: The development of BTRFS, Frederic Weisbecker

If we meet a bad extent type, find_updated_files is going
to print random things. Better warn the user about what
happens.

This fixes:

btrfs-list.c: Dans la fonction =C2=ABfind_updated_files=C2=BB :
btrfs-list.c:668: attention : =C2=ABdisk_offset=C2=BB may be used unini=
tialized in this function
btrfs-list.c:668: note: =C2=ABdisk_offset=C2=BB was declared here
btrfs-list.c:667: attention : =C2=ABdisk_start=C2=BB may be used uninit=
ialized in this function
btrfs-list.c:667: note: =C2=ABdisk_start=C2=BB was declared here
btrfs-list.c:666: attention : =C2=ABlen=C2=BB may be used uninitialized=
 in this function
btrfs-list.c:666: note: =C2=ABlen=C2=BB was declared here
make: *** [btrfs-list.o] Erreur 1

Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
---
 btrfs-list.c |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/btrfs-list.c b/btrfs-list.c
index 9dedb5d..c90a1e6 100644
--- a/btrfs-list.c
+++ b/btrfs-list.c
@@ -698,6 +698,15 @@ static int print_one_extent(int fd, struct btrfs_i=
octl_search_header *sh,
 		disk_start =3D 0;
 		disk_offset =3D 0;
 		len =3D btrfs_stack_file_extent_ram_bytes(item);
+	} else {
+		printf("unhandled extent type %d for inode %llu "
+		       "file offset %llu gen %llu\n",
+			type,
+			(unsigned long long)sh->objectid,
+			(unsigned long long)sh->offset,
+			(unsigned long long)found_gen);
+
+		return -EIO;
 	}
 	printf("inode %llu file offset %llu len %llu disk start %llu "
 	       "offset %llu gen %llu flags ",
--=20
1.5.4.3

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" =
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-06-28 16:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-06-28 16:55 [PATCH] Btrgs-progs: Define _GNU_SOURCE for strndup Frederic Weisbecker
2010-06-28 16:55 ` [PATCH] Btrfs-progs: Handle bad extent type case Frederic Weisbecker

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).