From: Nick Terrell <terrelln@fb.com>
To: David Sterba <dsterba@suse.cz>
Cc: "B093B859-53CC-4818-8CC3-A317F4872AD6@fb.com"
<B093B859-53CC-4818-8CC3-A317F4872AD6@fb.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL][PATCH v11 0/4] Update to zstd-1.4.10
Date: Wed, 29 Sep 2021 16:56:17 +0000 [thread overview]
Message-ID: <1584373E-34C9-4B0E-9E84-6C29F919EE38@fb.com> (raw)
In-Reply-To: <20210929100659.GK9286@twin.jikos.cz>
> On Sep 29, 2021, at 3:06 AM, David Sterba <dsterba@suse.cz> wrote:
>
> On Wed, Sep 29, 2021 at 01:30:26AM +0000, Nick Terrell wrote:
>>> On Sep 28, 2021, at 5:22 PM, Tom Seewald <tseewald@gmail.com> wrote:
>>> Has this been abandoned or will there be future attempts at syncing the
>>> in-kernel zstd with the upstream project?
>>
>> Sorry for the lack of action, but this has not been abandoned. I’ve just been
>> preparing a rebased patch-set last week, so expect to see some action soon.
>> Since we’re not in a merge window, I’m unsure if it is best to send out the
>> updated patches now, or wait until the merge window is open, but I’m about to
>> pose that question to the LKML.
>
> If you send it once merge window is open it's unlikely to be merged. The
> code must be ready before it opens and part of linux-next for a week at
> least if not more.
>
>> This work has been on my back burner, because I’ve been busy with work on
>> Zstd and other projects, and have had a hard time justifying to myself spending
>> too much time on this, since progress has been so slow.
>
> What needs to be done from my POV:
>
> - refresh the patches on top of current mainline, eg. v5.15-rc3
>
> - make sure it compiles and works with current in-kernel users of zstd,
> ie. with btrfs in particular, I can do some tests too
>
> - push the patches to a public branch eg. on k.org or github
>
> - ask for adding the branch to linux-next
>
> - try to get some feedback from people that were objecting in the past,
> and of course gather acks or supportive feedback
>
> - once merge window opens, send a pull request to Linus, write the
> rationale why we want this change and summarize the evolution of the
> patchset and why the full version update is perhaps the way forward
Thanks for the clear explanation, that was very helpful! I’ve already rebased
and re-tested myself. I’ll send out a request asking it to be added to linux-next,
and try to gather feedback/acks on that thread. I’ll prepare the rationale for the
linux-next request, so you all can get a chance to read it.
Thanks,
Nick
next prev parent reply other threads:[~2021-09-29 16:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 0:22 [GIT PULL][PATCH v11 0/4] Update to zstd-1.4.10 Tom Seewald
2021-09-29 0:55 ` Neal Gompa
2021-09-29 1:30 ` Nick Terrell
2021-09-29 10:06 ` David Sterba
2021-09-29 10:23 ` Paul Jones
2021-09-29 16:56 ` Nick Terrell [this message]
2021-09-29 20:02 ` Oleksandr Natalenko
-- strict thread matches above, loose matches on Subject: below --
2021-04-30 1:31 Nick Terrell
2021-05-11 20:53 ` Nick Terrell
2021-05-12 19:49 ` David Sterba
2021-06-11 20:06 ` Jean-Denis Girard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1584373E-34C9-4B0E-9E84-6C29F919EE38@fb.com \
--to=terrelln@fb.com \
--cc=B093B859-53CC-4818-8CC3-A317F4872AD6@fb.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).