From: David Sterba <dsterba@suse.cz>
To: Nick Terrell <terrelln@fb.com>
Cc: "Nick Terrell" <nickrterrell@gmail.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"Btrfs BTRFS" <linux-btrfs@vger.kernel.org>,
"squashfs-devel@lists.sourceforge.net"
<squashfs-devel@lists.sourceforge.net>,
"linux-f2fs-devel@lists.sourceforge.net"
<linux-f2fs-devel@lists.sourceforge.net>,
LKML <linux-kernel@vger.kernel.org>,
"Kernel Team" <Kernel-team@fb.com>, "Chris Mason" <clm@fb.com>,
"Petr Malat" <oss@malat.biz>, "Johannes Weiner" <jweiner@fb.com>,
"Niket Agarwal" <niketa@fb.com>, "Yann Collet" <cyan@fb.com>,
"Christoph Hellwig" <hch@infradead.org>,
"Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
"David Sterba" <dsterba@suse.cz>,
"Oleksandr Natalenko" <oleksandr@natalenko.name>,
"Felix Handte" <felixh@fb.com>,
"Eric Biggers" <ebiggers@kernel.org>,
"Randy Dunlap" <rdunlap@infradead.org>,
torvalds@linux-foundation.org
Subject: Re: [GIT PULL][PATCH v11 0/4] Update to zstd-1.4.10
Date: Wed, 12 May 2021 21:49:35 +0200 [thread overview]
Message-ID: <20210512194935.GY7604@twin.jikos.cz> (raw)
In-Reply-To: <B093B859-53CC-4818-8CC3-A317F4872AD6@fb.com>
On Tue, May 11, 2021 at 08:53:41PM +0000, Nick Terrell wrote:
> Pinging this series. Is there anything I should do to help get this
> merged?
>
> The use of zstd in the kernel is continuously increasing over time,
> both in terms of number of use cases, and number of users that
> actually enable zstd compression in production. E.g. Fedora is
> making btrfs with zstd compression enabled the default.
>
> I would love to see the zstd code updated to the latest upstream
> and be kept up to date. The latest upstream brings bug fixes, and
> significant performance improvements. Additionally, the latest
> upstream code is continuously fuzzed.
The btrfs community and I in particular have interest to get zstd
updated but also there's the patch 3 that goes against what kernel
requires regarding patch size and logical split of changes.
That the update is so large shouldn't have happened, it covers 3 years
of development, the syncs should have happened more often, but here we
are.
Other points that have been raised in the past:
* new wrappers - there are new wrappers changing users of the API, the
new names are more conforming, eg ZSTD_decompressDCtx -> zstd_decompress_dctx,
sounds like an improvement to me
* high stack usage - mentioned in patch 3, slight increase but bounded
and upstream now monitors that so it does not increase
Other points that are worth mentioning:
* bisectability - the version switch happens in one patch, so the
effects before/after the patch are only runtime as there's no change
in format etc, so ok
* will be maintained - no such huge update should happen again
So I suggest to merge in current form. I'm not sure what was the
original plan if it was supposed to go via Herbert's crypto tree, but
that was before Nick added himself as maintainer.
I think that Nick can send the pull request to Linus, perhaps with acks
to all changes that are in the non-zstd code (patch 1).
Cover letter v11: https://lore.kernel.org/linux-btrfs/20210430013157.747152-1-nickrterrell@gmail.com/
next prev parent reply other threads:[~2021-05-12 21:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-30 1:31 [GIT PULL][PATCH v11 0/4] Update to zstd-1.4.10 Nick Terrell
2021-04-30 1:31 ` [PATCH v11 1/4] lib: zstd: Add kernel-specific API Nick Terrell
2021-04-30 1:31 ` [PATCH v11 2/4] lib: zstd: Add decompress_sources.h for decompress_unzstd Nick Terrell
2021-04-30 1:31 ` [PATCH v11 4/4] MAINTAINERS: Add maintainer entry for zstd Nick Terrell
2021-05-11 20:53 ` [GIT PULL][PATCH v11 0/4] Update to zstd-1.4.10 Nick Terrell
2021-05-12 19:49 ` David Sterba [this message]
2021-06-11 20:06 ` Jean-Denis Girard
2021-09-29 0:22 Tom Seewald
2021-09-29 0:55 ` Neal Gompa
2021-09-29 1:30 ` Nick Terrell
2021-09-29 10:06 ` David Sterba
2021-09-29 10:23 ` Paul Jones
2021-09-29 16:56 ` Nick Terrell
2021-09-29 20:02 ` Oleksandr Natalenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210512194935.GY7604@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=Kernel-team@fb.com \
--cc=clm@fb.com \
--cc=cyan@fb.com \
--cc=ebiggers@kernel.org \
--cc=felixh@fb.com \
--cc=hch@infradead.org \
--cc=herbert@gondor.apana.org.au \
--cc=jweiner@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=nickrterrell@gmail.com \
--cc=niketa@fb.com \
--cc=oleksandr@natalenko.name \
--cc=oss@malat.biz \
--cc=rdunlap@infradead.org \
--cc=squashfs-devel@lists.sourceforge.net \
--cc=terrelln@fb.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).