* [PATCH] Btrfs: check return value of open_bdev_exclusive properly
@ 2010-01-27 2:09 Josef Bacik
0 siblings, 0 replies; only message in thread
From: Josef Bacik @ 2010-01-27 2:09 UTC (permalink / raw)
To: linux-btrfs
Hit this problem while testing RAID1 failure stuff. open_bdev_exclusive returns
ERR_PTR(), not NULL. So change the return value properly. This is important if
you accidently specify a device that doesn't exist when trying to add a new
device to an array, you will panic the box dereferencing bdev.
Signed-off-by: Josef Bacik <josef@redhat.com>
---
fs/btrfs/volumes.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index 68fe767..605ea5b 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -1434,8 +1434,8 @@ int btrfs_init_new_device(struct btrfs_root *root, char *device_path)
return -EINVAL;
bdev = open_bdev_exclusive(device_path, 0, root->fs_info->bdev_holder);
- if (!bdev)
- return -EIO;
+ if (IS_ERR(bdev))
+ return PTR_ERR(bdev);
if (root->fs_info->fs_devices->seeding) {
seeding_dev = 1;
--
1.5.4.3
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2010-01-27 2:09 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-01-27 2:09 [PATCH] Btrfs: check return value of open_bdev_exclusive properly Josef Bacik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).