* [PATCH] btrfs: Prevent creation of files larger than RLIMIT_FSIZE using fallocate
[not found] ` <20100503065945.GA13756@amitarora.in.ibm.com>
@ 2010-05-04 5:44 ` Nikanth Karthikesan
0 siblings, 0 replies; only message in thread
From: Nikanth Karthikesan @ 2010-05-04 5:44 UTC (permalink / raw)
To: Chris Mason
Cc: Amit K. Arora, Andrew Morton, coly.li, Nick Piggin,
Alexander Viro, linux-fsdevel, Theodore Ts'o, Andreas Dilger,
linux-ext4, Eelis, Amit Arora, Christoph Hellwig, linux-btrfs
Prevent creation of files larger than RLIMIT_FSIZE using fallocate.
Currently using posix_fallocate one can bypass an RLIMIT_FSIZE limit
and create a file larger than the limit. Add a check for that.
Signed-off-by: Nikanth Karthikesan <knikanth@suse.de>
---
diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
index 2bfdc64..a1d8fbc 100644
--- a/fs/btrfs/inode.c
+++ b/fs/btrfs/inode.c
@@ -5829,6 +5829,11 @@ static long btrfs_fallocate(struct inode *inode, int mode,
btrfs_wait_ordered_range(inode, alloc_start, alloc_end - alloc_start);
mutex_lock(&inode->i_mutex);
+
+ ret = inode_newsize_ok(inode, (offset + len));
+ if (ret)
+ goto out;
+
if (alloc_start > inode->i_size) {
ret = btrfs_cont_expand(inode, alloc_start);
if (ret)
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2010-05-04 5:44 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <201004281854.49730.knikanth@suse.de>
[not found] ` <201005030953.45157.knikanth@suse.de>
[not found] ` <20100503065945.GA13756@amitarora.in.ibm.com>
2010-05-04 5:44 ` [PATCH] btrfs: Prevent creation of files larger than RLIMIT_FSIZE using fallocate Nikanth Karthikesan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).