archive mirror
 help / color / mirror / Atom feed
* [patch 7/11] btrfs: unwind after btrfs_start_transaction() errors
@ 2010-05-29  9:46 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2010-05-29  9:46 UTC (permalink / raw)
  To: linux-btrfs
  Cc: Yan Zheng, Josef Bacik, Sage Weil, Chris Mason, kernel-janitors

This was added by a22285a6a3: "Btrfs: Integrate metadata reservation
with start_transaction".  If we goto out here then we skip all the
unwinding and there are locks still held etc.

Signed-off-by: Dan Carpenter <>

diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
index 4cdb98c..9f9a1d9 100644
--- a/fs/btrfs/ioctl.c
+++ b/fs/btrfs/ioctl.c
@@ -1280,7 +1280,7 @@ static noinline int btrfs_ioctl_snap_destroy(struct file *file,
 	trans = btrfs_start_transaction(root, 0);
 	if (IS_ERR(trans)) {
 		err = PTR_ERR(trans);
-		goto out;
+		goto out_up_write;
 	trans->block_rsv = &root->fs_info->global_block_rsv;

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2010-05-29  9:46 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-05-29  9:46 [patch 7/11] btrfs: unwind after btrfs_start_transaction() errors Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).