linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH btrfs-unstable#master] Prevent creation of files larger than RLIMIT_FSIZE using fallocate
@ 2010-06-16  8:30 Nikanth Karthikesan
  0 siblings, 0 replies; only message in thread
From: Nikanth Karthikesan @ 2010-06-16  8:30 UTC (permalink / raw)
  To: Chris Mason; +Cc: linux-btrfs, Amit K. Arora

Hi Chris

I am resending this based on the btrfs-unstable tree. Please apply/reply.

Thanks
Nikanth

Prevent creation of files larger than RLIMIT_FSIZE using fallocate.

Currently using posix_fallocate one can bypass an RLIMIT_FSIZE limit
and create a larger file than the limit. Add a check for that.


Signed-off-by: Nikanth Karthikesan <knikanth@suse.de>
Cc: Amit K. Arora <aarora@linux.vnet.ibm.com>

---

diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
index f08427c..7870f4f 100644
--- a/fs/btrfs/inode.c
+++ b/fs/btrfs/inode.c
@@ -6842,6 +6842,11 @@ static long btrfs_fallocate(struct inode *inode, int mode,
 	btrfs_wait_ordered_range(inode, alloc_start, alloc_end - alloc_start);
 
 	mutex_lock(&inode->i_mutex);
+
+	ret = inode_newsize_ok(inode, (offset + len));
+	if (ret)
+		goto out;
+
 	if (alloc_start > inode->i_size) {
 		ret = btrfs_cont_expand(inode, alloc_start);
 		if (ret)

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2010-06-16  8:30 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-06-16  8:30 [PATCH btrfs-unstable#master] Prevent creation of files larger than RLIMIT_FSIZE using fallocate Nikanth Karthikesan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).