* [PATCH] btrfs: free delayed node outside of root->inode_lock
@ 2014-05-27 17:53 Jeff Mahoney
2014-05-29 16:01 ` David Sterba
0 siblings, 1 reply; 2+ messages in thread
From: Jeff Mahoney @ 2014-05-27 17:53 UTC (permalink / raw)
To: linux-btrfs, David Sterba
On heavy workloads, we're seeing soft lockup warnings on
root->inode_lock in __btrfs_release_delayed_node. The low hanging fruit
is to reduce the size of the critical section.
Signed-off-by: Jeff Mahoney <jeffm@suse.com>
---
fs/btrfs/delayed-inode.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/fs/btrfs/delayed-inode.c b/fs/btrfs/delayed-inode.c
index 33e561a..da775bf 100644
--- a/fs/btrfs/delayed-inode.c
+++ b/fs/btrfs/delayed-inode.c
@@ -149,8 +149,8 @@ again:
spin_lock(&root->inode_lock);
ret = radix_tree_insert(&root->delayed_nodes_tree, ino, node);
if (ret == -EEXIST) {
- kmem_cache_free(delayed_node_cache, node);
spin_unlock(&root->inode_lock);
+ kmem_cache_free(delayed_node_cache, node);
radix_tree_preload_end();
goto again;
}
@@ -267,14 +267,17 @@ static void __btrfs_release_delayed_node(
mutex_unlock(&delayed_node->mutex);
if (atomic_dec_and_test(&delayed_node->refs)) {
+ bool free = false;
struct btrfs_root *root = delayed_node->root;
spin_lock(&root->inode_lock);
if (atomic_read(&delayed_node->refs) == 0) {
radix_tree_delete(&root->delayed_nodes_tree,
delayed_node->inode_id);
- kmem_cache_free(delayed_node_cache, delayed_node);
+ free = true;
}
spin_unlock(&root->inode_lock);
+ if (free)
+ kmem_cache_free(delayed_node_cache, delayed_node);
}
}
--
Jeff Mahoney
SUSE Labs
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] btrfs: free delayed node outside of root->inode_lock
2014-05-27 17:53 [PATCH] btrfs: free delayed node outside of root->inode_lock Jeff Mahoney
@ 2014-05-29 16:01 ` David Sterba
0 siblings, 0 replies; 2+ messages in thread
From: David Sterba @ 2014-05-29 16:01 UTC (permalink / raw)
To: Jeff Mahoney; +Cc: linux-btrfs
On Tue, May 27, 2014 at 01:53:20PM -0400, Jeff Mahoney wrote:
> On heavy workloads, we're seeing soft lockup warnings on
> root->inode_lock in __btrfs_release_delayed_node. The low hanging fruit
> is to reduce the size of the critical section.
>
> Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Reviewed-by: David Sterba <dsterba@suse.cz>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-29 16:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-27 17:53 [PATCH] btrfs: free delayed node outside of root->inode_lock Jeff Mahoney
2014-05-29 16:01 ` David Sterba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).