linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] btrfs-progs: make pretty Documentation/ build match the rest
@ 2014-05-30 16:27 Eric Sandeen
  2014-06-12  9:41 ` David Sterba
  0 siblings, 1 reply; 2+ messages in thread
From: Eric Sandeen @ 2014-05-30 16:27 UTC (permalink / raw)
  To: linux-btrfs

This is the most important patch ever.  ;)

I found this to be less aesthetically pleasing than it was before:

     [CC]     btrfstune.o
 Making all in Documentation
     ASCIIDOC btrfs-convert.xml
     [LD]     btrfstune
     XMLTO btrfs-convert.8
     [CC]     btrfs-show-super.o
     GZIP btrfs-convert.8.gz
     [LD]     btrfs-show-super
     ASCIIDOC btrfs-debug-tree.xml
     XMLTO btrfs-debug-tree.8

so I shortened the pretty-text to match what we had before.

Also, make clean "quiet" like it is in the top dir.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

If folks don't like the 2-letter abbreviations, obviously the
patch just isn't that important.

diff --git a/Documentation/Makefile b/Documentation/Makefile
index 45299bb..03a5cd5 100644
--- a/Documentation/Makefile
+++ b/Documentation/Makefile
@@ -54,9 +54,10 @@ BTRFS_VERSION = $(shell sed -n 's/.*BTRFS_BUILD_VERSION "Btrfs \(.*\)"/\1/p'\
 
 ifneq ($(findstring $(MAKEFLAGS),s),s)
 ifndef V
-	QUIET_ASCIIDOC	= @echo '   ' ASCIIDOC $@;
-	QUIET_XMLTO	= @echo '   ' XMLTO $@;
-	QUIET_GZIP	= @echo '   ' GZIP $@;
+	QUIET_RM	= @
+	QUIET_ASCIIDOC	= @echo "    [AD]     $@";
+	QUIET_XMLTO	= @echo "    [XT]     $@";
+	QUIET_GZIP	= @echo "    [GZ]     $@";
 	QUIET_STDERR	= 2> /dev/null
 	QUIET_SUBDIR0	= +@subdir=
 	QUIET_SUBDIR1	= ;$(NO_SUBDIR) echo '   ' SUBDIR $$subdir; \
@@ -77,7 +78,7 @@ install-man: man
 	$(LNS) btrfs-check.8.gz $(DESTDIR)$(man8dir)
 
 clean:
-	$(RM) *.xml *.xml+ *.8 *.8.gz
+	$(QUIET_RM)$(RM) *.xml *.xml+ *.8 *.8.gz
 
 %.8.gz : %.8
 	$(QUIET_GZIP)$(GZIP) -n -c $< > $@


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] btrfs-progs: make pretty Documentation/ build match the rest
  2014-05-30 16:27 [PATCH] btrfs-progs: make pretty Documentation/ build match the rest Eric Sandeen
@ 2014-06-12  9:41 ` David Sterba
  0 siblings, 0 replies; 2+ messages in thread
From: David Sterba @ 2014-06-12  9:41 UTC (permalink / raw)
  To: Eric Sandeen; +Cc: linux-btrfs

On Fri, May 30, 2014 at 11:27:14AM -0500, Eric Sandeen wrote:
> This is the most important patch ever.  ;)

Oh it is :)

> I found this to be less aesthetically pleasing than it was before:
> 
>      [CC]     btrfstune.o
>  Making all in Documentation
>      ASCIIDOC btrfs-convert.xml
>      [LD]     btrfstune
>      XMLTO btrfs-convert.8
>      [CC]     btrfs-show-super.o
>      GZIP btrfs-convert.8.gz
>      [LD]     btrfs-show-super
>      ASCIIDOC btrfs-debug-tree.xml
>      XMLTO btrfs-debug-tree.8
> 
> If folks don't like the 2-letter abbreviations, obviously the
> patch just isn't that important.

I like the prettyfied output, but XT or AD look unfamiliar in this context.
I've tried a few tweaks, is this change ok for you?

    [LD]     btrfs-show-super
    [ASCII]  btrfs-property.xml
    [XMLTO]  btrfs-debug-tree.8
    [XMLTO]  btrfstune.8
    [LD]     btrfs-image

Full ASCIIDOC would need to update all the two-letter strings, does not
seem justified.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-06-12  9:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-30 16:27 [PATCH] btrfs-progs: make pretty Documentation/ build match the rest Eric Sandeen
2014-06-12  9:41 ` David Sterba

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).