* [PATCH] btrfs: btrfs_shrink_device should call commit transaction
@ 2018-07-25 13:27 Anand Jain
2018-07-25 16:52 ` Lu Fengqi
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Anand Jain @ 2018-07-25 13:27 UTC (permalink / raw)
To: linux-btrfs
test case btrfs/164 reported UAF..
[ 6712.084324] general protection fault: 0000 [#1] PREEMPT SMP
::
[ 6712.195423] btrfs_update_commit_device_size+0x75/0xf0 [btrfs]
[ 6712.201424] btrfs_commit_transaction+0x57d/0xa90 [btrfs]
[ 6712.206999] btrfs_rm_device+0x627/0x850 [btrfs]
[ 6712.211800] btrfs_ioctl+0x2b03/0x3120 [btrfs]
::
reason for this is that btrfs_shrink_device() adds the device resized to
the fs_devices::resized_devices after it has called the last commit
transaction.
So the list fs_devices::resized_devices is not empty when
btrfs_shrink_device() returns.
Now the parent function btrfs_rm_device() calls
btrfs_close_bdev(device);
call_rcu(&device->rcu, free_device_rcu);
and then does the commit transaction.
The commit transaction goes through the fs_devices::resized_devices
in btrfs_update_commit_device_size() and leads to UAF.
Fix this by making sure btrfs_shrink_device() calls the last needed
btrfs_commit_transaction() before the return.
Signed-off-by: Anand Jain <anand.jain@oracle.com>
---
I am bit skeptical about the condition when btrfs_commit_transaction()
fails, can you pls be wary about it when reviewing. Thanks.
Lu/David,
As this issues isn't reproducible at my end, can you pls test this
patch on top of the patch
btrfs: fix missing superblock update in the device delete commit transaction
Thanks.
fs/btrfs/volumes.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index 418843b8f8e8..344083cc811c 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -4464,7 +4464,10 @@ int btrfs_shrink_device(struct btrfs_device *device, u64 new_size)
/* Now btrfs_update_device() will change the on-disk size. */
ret = btrfs_update_device(trans, device);
- btrfs_end_transaction(trans);
+ if (ret)
+ btrfs_end_transaction(trans);
+ else
+ ret = btrfs_commit_transaction(trans);
done:
btrfs_free_path(path);
if (ret) {
--
2.7.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] btrfs: btrfs_shrink_device should call commit transaction
2018-07-25 13:27 [PATCH] btrfs: btrfs_shrink_device should call commit transaction Anand Jain
@ 2018-07-25 16:52 ` Lu Fengqi
2018-07-30 14:18 ` Nikolay Borisov
2018-08-06 10:12 ` [PATCH v2] " Anand Jain
2 siblings, 0 replies; 7+ messages in thread
From: Lu Fengqi @ 2018-07-25 16:52 UTC (permalink / raw)
To: Anand Jain; +Cc: linux-btrfs
On Wed, Jul 25, 2018 at 09:27:27PM +0800, Anand Jain wrote:
>test case btrfs/164 reported UAF..
>
>[ 6712.084324] general protection fault: 0000 [#1] PREEMPT SMP
>::
>[ 6712.195423] btrfs_update_commit_device_size+0x75/0xf0 [btrfs]
>[ 6712.201424] btrfs_commit_transaction+0x57d/0xa90 [btrfs]
>[ 6712.206999] btrfs_rm_device+0x627/0x850 [btrfs]
>[ 6712.211800] btrfs_ioctl+0x2b03/0x3120 [btrfs]
>::
>
>reason for this is that btrfs_shrink_device() adds the device resized to
>the fs_devices::resized_devices after it has called the last commit
>transaction.
>So the list fs_devices::resized_devices is not empty when
>btrfs_shrink_device() returns.
>Now the parent function btrfs_rm_device() calls
> btrfs_close_bdev(device);
> call_rcu(&device->rcu, free_device_rcu);
>and then does the commit transaction.
>The commit transaction goes through the fs_devices::resized_devices
>in btrfs_update_commit_device_size() and leads to UAF.
>
>Fix this by making sure btrfs_shrink_device() calls the last needed
>btrfs_commit_transaction() before the return.
>
>Signed-off-by: Anand Jain <anand.jain@oracle.com>
>---
>I am bit skeptical about the condition when btrfs_commit_transaction()
>fails, can you pls be wary about it when reviewing. Thanks.
>
>Lu/David,
>As this issues isn't reproducible at my end, can you pls test this
>patch on top of the patch
> btrfs: fix missing superblock update in the device delete commit transaction
Tested-by: Lu Fengqi <lufq.fnst@cn.fujitsu.com>
--
Thanks,
Lu
>Thanks.
>
> fs/btrfs/volumes.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
>index 418843b8f8e8..344083cc811c 100644
>--- a/fs/btrfs/volumes.c
>+++ b/fs/btrfs/volumes.c
>@@ -4464,7 +4464,10 @@ int btrfs_shrink_device(struct btrfs_device *device, u64 new_size)
>
> /* Now btrfs_update_device() will change the on-disk size. */
> ret = btrfs_update_device(trans, device);
>- btrfs_end_transaction(trans);
>+ if (ret)
>+ btrfs_end_transaction(trans);
>+ else
>+ ret = btrfs_commit_transaction(trans);
> done:
> btrfs_free_path(path);
> if (ret) {
>--
>2.7.0
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] btrfs: btrfs_shrink_device should call commit transaction
2018-07-25 13:27 [PATCH] btrfs: btrfs_shrink_device should call commit transaction Anand Jain
2018-07-25 16:52 ` Lu Fengqi
@ 2018-07-30 14:18 ` Nikolay Borisov
2018-08-03 11:27 ` Anand Jain
2018-08-06 10:12 ` [PATCH v2] " Anand Jain
2 siblings, 1 reply; 7+ messages in thread
From: Nikolay Borisov @ 2018-07-30 14:18 UTC (permalink / raw)
To: Anand Jain, linux-btrfs
On 25.07.2018 16:27, Anand Jain wrote:
> test case btrfs/164 reported UAF..
>
> [ 6712.084324] general protection fault: 0000 [#1] PREEMPT SMP
> ::
> [ 6712.195423] btrfs_update_commit_device_size+0x75/0xf0 [btrfs]
> [ 6712.201424] btrfs_commit_transaction+0x57d/0xa90 [btrfs]
> [ 6712.206999] btrfs_rm_device+0x627/0x850 [btrfs]
> [ 6712.211800] btrfs_ioctl+0x2b03/0x3120 [btrfs]
> ::
>
> reason for this is that btrfs_shrink_device() adds the device resized to
> the fs_devices::resized_devices after it has called the last commit
> transaction.
> So the list fs_devices::resized_devices is not empty when
> btrfs_shrink_device() returns.
> Now the parent function btrfs_rm_device() calls
> btrfs_close_bdev(device);
> call_rcu(&device->rcu, free_device_rcu);
> and then does the commit transaction.
> The commit transaction goes through the fs_devices::resized_devices
> in btrfs_update_commit_device_size() and leads to UAF.
>
> Fix this by making sure btrfs_shrink_device() calls the last needed
> btrfs_commit_transaction() before the return.
>
> Signed-off-by: Anand Jain <anand.jain@oracle.com>
> ---
> I am bit skeptical about the condition when btrfs_commit_transaction()
> fails, can you pls be wary about it when reviewing. Thanks.
>
> Lu/David,
> As this issues isn't reproducible at my end, can you pls test this
> patch on top of the patch
> btrfs: fix missing superblock update in the device delete commit transaction
> Thanks.
>
> fs/btrfs/volumes.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
> index 418843b8f8e8..344083cc811c 100644
> --- a/fs/btrfs/volumes.c
> +++ b/fs/btrfs/volumes.c
> @@ -4464,7 +4464,10 @@ int btrfs_shrink_device(struct btrfs_device *device, u64 new_size)
>
> /* Now btrfs_update_device() will change the on-disk size. */
> ret = btrfs_update_device(trans, device);
> - btrfs_end_transaction(trans);
> + if (ret)
> + btrfs_end_transaction(trans);
Why don't you call btrfs_abort_transaction on error from
btrfs_update_device?
> + else
> + ret = btrfs_commit_transaction(trans);
> done:
> btrfs_free_path(path);
> if (ret) {
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] btrfs: btrfs_shrink_device should call commit transaction
2018-07-30 14:18 ` Nikolay Borisov
@ 2018-08-03 11:27 ` Anand Jain
2018-08-03 11:34 ` Nikolay Borisov
0 siblings, 1 reply; 7+ messages in thread
From: Anand Jain @ 2018-08-03 11:27 UTC (permalink / raw)
To: Nikolay Borisov, linux-btrfs
On 07/30/2018 10:18 PM, Nikolay Borisov wrote:
>
>
> On 25.07.2018 16:27, Anand Jain wrote:
>> test case btrfs/164 reported UAF..
>>
>> [ 6712.084324] general protection fault: 0000 [#1] PREEMPT SMP
>> ::
>> [ 6712.195423] btrfs_update_commit_device_size+0x75/0xf0 [btrfs]
>> [ 6712.201424] btrfs_commit_transaction+0x57d/0xa90 [btrfs]
>> [ 6712.206999] btrfs_rm_device+0x627/0x850 [btrfs]
>> [ 6712.211800] btrfs_ioctl+0x2b03/0x3120 [btrfs]
>> ::
>>
>> reason for this is that btrfs_shrink_device() adds the device resized to
>> the fs_devices::resized_devices after it has called the last commit
>> transaction.
>> So the list fs_devices::resized_devices is not empty when
>> btrfs_shrink_device() returns.
>> Now the parent function btrfs_rm_device() calls
>> btrfs_close_bdev(device);
>> call_rcu(&device->rcu, free_device_rcu);
>> and then does the commit transaction.
>> The commit transaction goes through the fs_devices::resized_devices
>> in btrfs_update_commit_device_size() and leads to UAF.
>>
>> Fix this by making sure btrfs_shrink_device() calls the last needed
>> btrfs_commit_transaction() before the return.
>>
>> Signed-off-by: Anand Jain <anand.jain@oracle.com>
>> ---
>> I am bit skeptical about the condition when btrfs_commit_transaction()
>> fails, can you pls be wary about it when reviewing. Thanks.
>>
>> Lu/David,
>> As this issues isn't reproducible at my end, can you pls test this
>> patch on top of the patch
>> btrfs: fix missing superblock update in the device delete commit transaction
>> Thanks.
>>
>> fs/btrfs/volumes.c | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
>> index 418843b8f8e8..344083cc811c 100644
>> --- a/fs/btrfs/volumes.c
>> +++ b/fs/btrfs/volumes.c
>> @@ -4464,7 +4464,10 @@ int btrfs_shrink_device(struct btrfs_device *device, u64 new_size)
>>
>> /* Now btrfs_update_device() will change the on-disk size. */
>> ret = btrfs_update_device(trans, device);
>> - btrfs_end_transaction(trans);
>> + if (ret)
>> + btrfs_end_transaction(trans);
>
> Why don't you call btrfs_abort_transaction on error from
> btrfs_update_device?
I still can't figure out, any idea why btrfs_abort_transaction?
Per other codes, we are mixing the use of btrfs_abort_transaction and
btrfs_end_transaction for the user initiated threads where
if the thread fails (after btrfs_start_transaction), IMO
we should let the user to try again. But btrfs_abort_transaction
doesn't provide such a choice consistently as it would endup
in RO.
----
static noinline int btrfs_ioctl_resize(struct file *file,
void __user *arg)
{
::
ret = btrfs_grow_device(trans, device, new_size);
btrfs_commit_transaction(trans); <--Bug? ret is not
checked.
----
static int __btrfs_balance(struct btrfs_fs_info *fs_info)
{
::
ret = btrfs_grow_device(trans, device, old_size);
if (ret) {
btrfs_end_transaction(trans);
-----
static noinline int btrfs_ioctl_subvol_setflags(struct file *file,
void __user *arg)
{
::
trans = btrfs_start_transaction(root, 1);
if (IS_ERR(trans)) {
ret = PTR_ERR(trans);
goto out_reset;
}
ret = btrfs_update_root(trans, fs_info->tree_root,
&root->root_key, &root->root_item);
if (ret < 0) {
btrfs_end_transaction(trans);
goto out_reset;
}
ret = btrfs_commit_transaction(trans);
----
static int btrfs_clone(struct inode *src, struct inode *inode,
const u64 off, const u64 olen, const u64
olen_aligned,
const u64 destoff, int no_time_update)
{
trans = btrfs_start_transaction(root, 3);
::
if (ret) {
if (ret != -EOPNOTSUPP)
btrfs_abort_transaction(trans, ret);
btrfs_end_transaction(trans);
goto out;
}
------
::
Thanks, Anand
>> + else
>> + ret = btrfs_commit_transaction(trans);
>> done:
>> btrfs_free_path(path);
>> if (ret) {
>>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] btrfs: btrfs_shrink_device should call commit transaction
2018-08-03 11:27 ` Anand Jain
@ 2018-08-03 11:34 ` Nikolay Borisov
0 siblings, 0 replies; 7+ messages in thread
From: Nikolay Borisov @ 2018-08-03 11:34 UTC (permalink / raw)
To: Anand Jain, linux-btrfs
On 3.08.2018 14:27, Anand Jain wrote:
>
>
> On 07/30/2018 10:18 PM, Nikolay Borisov wrote:
>>
>>
>> On 25.07.2018 16:27, Anand Jain wrote:
>>> test case btrfs/164 reported UAF..
>>>
>>> [ 6712.084324] general protection fault: 0000 [#1] PREEMPT SMP
>>> ::
>>> [ 6712.195423] btrfs_update_commit_device_size+0x75/0xf0 [btrfs]
>>> [ 6712.201424] btrfs_commit_transaction+0x57d/0xa90 [btrfs]
>>> [ 6712.206999] btrfs_rm_device+0x627/0x850 [btrfs]
>>> [ 6712.211800] btrfs_ioctl+0x2b03/0x3120 [btrfs]
>>> ::
>>>
>>> reason for this is that btrfs_shrink_device() adds the device resized to
>>> the fs_devices::resized_devices after it has called the last commit
>>> transaction.
>>> So the list fs_devices::resized_devices is not empty when
>>> btrfs_shrink_device() returns.
>>> Now the parent function btrfs_rm_device() calls
>>> btrfs_close_bdev(device);
>>> call_rcu(&device->rcu, free_device_rcu);
>>> and then does the commit transaction.
>>> The commit transaction goes through the fs_devices::resized_devices
>>> in btrfs_update_commit_device_size() and leads to UAF.
>>>
>>> Fix this by making sure btrfs_shrink_device() calls the last needed
>>> btrfs_commit_transaction() before the return.
>>>
>>> Signed-off-by: Anand Jain <anand.jain@oracle.com>
>>> ---
>>> I am bit skeptical about the condition when btrfs_commit_transaction()
>>> fails, can you pls be wary about it when reviewing. Thanks.
>>>
>>> Lu/David,
>>> As this issues isn't reproducible at my end, can you pls test this
>>> patch on top of the patch
>>> btrfs: fix missing superblock update in the device delete commit
>>> transaction
>>> Thanks.
>>>
>>> fs/btrfs/volumes.c | 5 ++++-
>>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
>>> index 418843b8f8e8..344083cc811c 100644
>>> --- a/fs/btrfs/volumes.c
>>> +++ b/fs/btrfs/volumes.c
>>> @@ -4464,7 +4464,10 @@ int btrfs_shrink_device(struct btrfs_device
>>> *device, u64 new_size)
>>> /* Now btrfs_update_device() will change the on-disk size. */
>>> ret = btrfs_update_device(trans, device);
>>> - btrfs_end_transaction(trans);
>>> + if (ret)
>>> + btrfs_end_transaction(trans);
>>
>> Why don't you call btrfs_abort_transaction on error from
>> btrfs_update_device?
>
> I still can't figure out, any idea why btrfs_abort_transaction?
> Per other codes, we are mixing the use of btrfs_abort_transaction and
> btrfs_end_transaction for the user initiated threads where
> if the thread fails (after btrfs_start_transaction), IMO
> we should let the user to try again. But btrfs_abort_transaction
> doesn't provide such a choice consistently as it would endup
> in RO.
>
> ----
> static noinline int btrfs_ioctl_resize(struct file *file,
> void __user *arg)
> {
> ::
> ret = btrfs_grow_device(trans, device, new_size);
> btrfs_commit_transaction(trans); <--Bug? ret is not
> checked.
Yep, this is a bug, btrfs_grow_device can return
EACCESS/EINVAL/ENOMEM/ENOENT (the last two from btrfs_update_device) so
the return value must be checked and transaction aborted IMO.
> ----
> static int __btrfs_balance(struct btrfs_fs_info *fs_info)
> {
> ::
> ret = btrfs_grow_device(trans, device, old_size);
> if (ret) {
> btrfs_end_transaction(trans);
I think this is wrong as well, btrfs_grow_device can fail and neither it
nor it's callees call btrfs_abort_transaction.
> -----
> static noinline int btrfs_ioctl_subvol_setflags(struct file *file,
> void __user *arg)
> {
> ::
> trans = btrfs_start_transaction(root, 1);
> if (IS_ERR(trans)) {
> ret = PTR_ERR(trans);
> goto out_reset;
> }
>
> ret = btrfs_update_root(trans, fs_info->tree_root,
> &root->root_key, &root->root_item);
> if (ret < 0) {
> btrfs_end_transaction(trans);
> goto out_reset;
> }
btrfs_update_root calls btrfs_abort_transaction in all ret < 0 branches
hence the outter caller can simply call btrfs_end_transaction. In case
search_slot returns > 0 a BUG_ON is triggered.
Clearly there is a discrepancy in the code base as to who is reponsible
for aborting the transaction - the callee or the caller. In this case
it's the callee.
>
> ret = btrfs_commit_transaction(trans);
> ----
> static int btrfs_clone(struct inode *src, struct inode *inode,
> const u64 off, const u64 olen, const u64
> olen_aligned,
> const u64 destoff, int no_time_update)
> {
>
> trans = btrfs_start_transaction(root, 3);
> ::
> if (ret) {
> if (ret != -EOPNOTSUPP)
> btrfs_abort_transaction(trans, ret);
> btrfs_end_transaction(trans);
> goto out;
> }
> ------
> ::
>
> Thanks, Anand
>
>>> + else
>>> + ret = btrfs_commit_transaction(trans);
>>> done:
>>> btrfs_free_path(path);
>>> if (ret) {
>>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2] btrfs: btrfs_shrink_device should call commit transaction
2018-07-25 13:27 [PATCH] btrfs: btrfs_shrink_device should call commit transaction Anand Jain
2018-07-25 16:52 ` Lu Fengqi
2018-07-30 14:18 ` Nikolay Borisov
@ 2018-08-06 10:12 ` Anand Jain
2018-08-17 14:04 ` David Sterba
2 siblings, 1 reply; 7+ messages in thread
From: Anand Jain @ 2018-08-06 10:12 UTC (permalink / raw)
To: linux-btrfs
test case btrfs/164 reported UAF..
[ 6712.084324] general protection fault: 0000 [#1] PREEMPT SMP
::
[ 6712.195423] btrfs_update_commit_device_size+0x75/0xf0 [btrfs]
[ 6712.201424] btrfs_commit_transaction+0x57d/0xa90 [btrfs]
[ 6712.206999] btrfs_rm_device+0x627/0x850 [btrfs]
[ 6712.211800] btrfs_ioctl+0x2b03/0x3120 [btrfs]
::
reason for this is that btrfs_shrink_device() adds the device resized to
the fs_devices::resized_devices after it has called the last commit
transaction.
So the list fs_devices::resized_devices is not empty when
btrfs_shrink_device() returns.
Now the parent function btrfs_rm_device() calls
btrfs_close_bdev(device);
call_rcu(&device->rcu, free_device_rcu);
and then does the commit transaction.
The commit transaction goes through the fs_devices::resized_devices
in btrfs_update_commit_device_size() and leads to UAF.
Fix this by making sure btrfs_shrink_device() calls the last needed
btrfs_commit_transaction() before the return.
Reported-by: Lu Fengqi <lufq.fnst@cn.fujitsu.com>
Signed-off-by: Anand Jain <anand.jain@oracle.com>
Tested-by: Lu Fengqi <lufq.fnst@cn.fujitsu.com>
---
v1->v2: cleanup the dirty and new meta block group before ending
the transaction when btrfs_update_device fails.
fs/btrfs/volumes.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index da86706123ff..f4405e430da6 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -4491,7 +4491,12 @@ int btrfs_shrink_device(struct btrfs_device *device, u64 new_size)
/* Now btrfs_update_device() will change the on-disk size. */
ret = btrfs_update_device(trans, device);
- btrfs_end_transaction(trans);
+ if (ret < 0) {
+ btrfs_abort_transaction(trans, ret);
+ btrfs_end_transaction(trans);
+ } else {
+ ret = btrfs_commit_transaction(trans);
+ }
done:
btrfs_free_path(path);
if (ret) {
--
2.7.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2] btrfs: btrfs_shrink_device should call commit transaction
2018-08-06 10:12 ` [PATCH v2] " Anand Jain
@ 2018-08-17 14:04 ` David Sterba
0 siblings, 0 replies; 7+ messages in thread
From: David Sterba @ 2018-08-17 14:04 UTC (permalink / raw)
To: Anand Jain; +Cc: linux-btrfs
On Mon, Aug 06, 2018 at 06:12:37PM +0800, Anand Jain wrote:
> test case btrfs/164 reported UAF..
>
> [ 6712.084324] general protection fault: 0000 [#1] PREEMPT SMP
> ::
> [ 6712.195423] btrfs_update_commit_device_size+0x75/0xf0 [btrfs]
> [ 6712.201424] btrfs_commit_transaction+0x57d/0xa90 [btrfs]
> [ 6712.206999] btrfs_rm_device+0x627/0x850 [btrfs]
> [ 6712.211800] btrfs_ioctl+0x2b03/0x3120 [btrfs]
> ::
>
> reason for this is that btrfs_shrink_device() adds the device resized to
> the fs_devices::resized_devices after it has called the last commit
> transaction.
> So the list fs_devices::resized_devices is not empty when
> btrfs_shrink_device() returns.
> Now the parent function btrfs_rm_device() calls
> btrfs_close_bdev(device);
> call_rcu(&device->rcu, free_device_rcu);
> and then does the commit transaction.
> The commit transaction goes through the fs_devices::resized_devices
> in btrfs_update_commit_device_size() and leads to UAF.
>
> Fix this by making sure btrfs_shrink_device() calls the last needed
> btrfs_commit_transaction() before the return.
>
> Reported-by: Lu Fengqi <lufq.fnst@cn.fujitsu.com>
> Signed-off-by: Anand Jain <anand.jain@oracle.com>
> Tested-by: Lu Fengqi <lufq.fnst@cn.fujitsu.com>
The transaction commit makes more sense here, also is consistent with
what grow does.
Reviewed-by: David Sterba <dsterba@suse.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-08-17 17:08 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-25 13:27 [PATCH] btrfs: btrfs_shrink_device should call commit transaction Anand Jain
2018-07-25 16:52 ` Lu Fengqi
2018-07-30 14:18 ` Nikolay Borisov
2018-08-03 11:27 ` Anand Jain
2018-08-03 11:34 ` Nikolay Borisov
2018-08-06 10:12 ` [PATCH v2] " Anand Jain
2018-08-17 14:04 ` David Sterba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).