From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Nikolay Borisov <nborisov@suse.com>
Cc: Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: no need to check return value of debugfs_create functions
Date: Fri, 4 Jan 2019 15:07:34 +0100 [thread overview]
Message-ID: <20190104140734.GA8970@kroah.com> (raw)
In-Reply-To: <a7d48bec-515c-164f-b5ee-1903ef98ef8d@suse.com>
On Fri, Jan 04, 2019 at 03:36:59PM +0200, Nikolay Borisov wrote:
>
>
> On 4.01.19 г. 15:25 ч., Greg Kroah-Hartman wrote:
> > When calling debugfs functions, there is no need to ever check the
> > return value. The function can work or not, but the code logic should
> > never do something different based on this.
> >
> > Cc: Chris Mason <clm@fb.com>
> > Cc: Josef Bacik <josef@toxicpanda.com>
> > Cc: David Sterba <dsterba@suse.com>
> > Cc: linux-btrfs@vger.kernel.org
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > ---
> > fs/btrfs/sysfs.c | 10 ++--------
> > 1 file changed, 2 insertions(+), 8 deletions(-)
> >
> > Meta-comment, why is there a btrfs debugfs directory at all? All you
> > have here is a single "test" file that doesn't do anything except expose
> > a variable that never changes. What is this directory and single file
> > for? Can I just delete the whole thing?
> >
>
> git blame is your friend - 1bae30982bc8 ("btrfs: add simple debugfs
> interface")
>
>
> Apparently David had an idea to do something but it never materialized,
> imo the debugfs bits could be removed from sysfs.c
Ok, I'll gladly delete all of the code if the maintainers will accept
such a patch.
thanks,
greg k-h
next prev parent reply other threads:[~2019-01-04 14:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-04 13:25 [PATCH] btrfs: no need to check return value of debugfs_create functions Greg Kroah-Hartman
2019-01-04 13:36 ` Nikolay Borisov
2019-01-04 14:07 ` Greg Kroah-Hartman [this message]
2019-01-04 13:44 ` David Sterba
2019-01-14 14:21 ` Greg Kroah-Hartman
2019-01-24 16:36 ` David Sterba
2019-02-01 9:17 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190104140734.GA8970@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).