From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v4 3/7] btrfs: relocation: Delay reloc tree deletion after merge_reloc_roots()
Date: Tue, 22 Jan 2019 17:32:58 +0100 [thread overview]
Message-ID: <20190122163258.GM2900@twin.jikos.cz> (raw)
In-Reply-To: <20190115081604.785-4-wqu@suse.com>
On Tue, Jan 15, 2019 at 04:16:00PM +0800, Qu Wenruo wrote:
> And to co-operate this, also delayed btrfs_drop_snapshot() call on reloc
> tree, btrfs_drop_snapshot() call will also be delayed to
> clean_dirty_subvs().
Can you please rephrase this paragraph?
> This patch will increase the size of btrfs_root by 16 bytes.
>
> Signed-off-by: Qu Wenruo <wqu@suse.com>
> +static int clean_dirty_subvs(struct reloc_control *rc)
> +{
> + struct btrfs_root *root;
> + struct btrfs_root *next;
> + int err = 0;
> + int ret;
> +
> + list_for_each_entry_safe(root, next, &rc->dirty_subv_roots,
> + reloc_dirty_list) {
> + struct btrfs_root *reloc_root = root->reloc_root;
> +
> + clear_bit(BTRFS_ROOT_DEAD_RELOC_TREE, &root->state);
> + list_del_init(&root->reloc_dirty_list);
> + root->reloc_root = NULL;
> + if (reloc_root) {
> + ret = btrfs_drop_snapshot(reloc_root, NULL, 0, 1);
> + if (ret < 0 && !err)
> + err = ret;
> + }
> + btrfs_put_fs_root(root);
> + }
> + return err;
Please dont use the err/ret style but 'ret' that matches function return
type and for the temporary return values ret2 etc.
> +}
next prev parent reply other threads:[~2019-01-22 16:33 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 8:15 [PATCH v4 0/7] btrfs: qgroup: Delay subtree scan to reduce overhead Qu Wenruo
2019-01-15 8:15 ` [PATCH v4 1/7] btrfs: qgroup: Move reserved data account from btrfs_delayed_ref_head to btrfs_qgroup_extent_record Qu Wenruo
2019-01-15 8:15 ` [PATCH v4 2/7] btrfs: qgroup: Don't trigger backref walk at delayed ref insert time Qu Wenruo
2019-01-15 8:16 ` [PATCH v4 3/7] btrfs: relocation: Delay reloc tree deletion after merge_reloc_roots() Qu Wenruo
2019-01-22 16:32 ` David Sterba [this message]
2019-01-23 6:01 ` Qu Wenruo
2019-01-15 8:16 ` [PATCH v4 4/7] btrfs: qgroup: Refactor btrfs_qgroup_trace_subtree_swap() Qu Wenruo
2019-01-22 16:38 ` David Sterba
2019-01-15 8:16 ` [PATCH v4 5/7] btrfs: qgroup: Introduce per-root swapped blocks infrastructure Qu Wenruo
2019-01-22 16:55 ` David Sterba
2019-01-22 23:07 ` Qu Wenruo
2019-01-24 18:44 ` David Sterba
2019-01-15 8:16 ` [PATCH v4 6/7] btrfs: qgroup: Use delayed subtree rescan for balance Qu Wenruo
2019-01-22 17:05 ` David Sterba
2019-01-15 8:16 ` [PATCH v4 7/7] btrfs: qgroup: Cleanup old subtree swap code Qu Wenruo
2019-01-15 17:26 ` [PATCH v4 0/7] btrfs: qgroup: Delay subtree scan to reduce overhead Josef Bacik
2019-01-16 0:31 ` Qu Wenruo
2019-01-16 1:07 ` Qu Wenruo
2019-01-16 1:15 ` Josef Bacik
2019-01-16 1:29 ` Qu Wenruo
2019-01-16 1:34 ` Josef Bacik
2019-01-16 1:36 ` Qu Wenruo
2019-01-22 16:28 ` David Sterba
2019-01-23 5:43 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190122163258.GM2900@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).