* [PATCH] btrfs: extent-io: Remove the incorrect comment on RO fs when btrfs_run_delalloc_range() fails
@ 2019-05-09 7:31 Qu Wenruo
2019-05-09 7:43 ` Nikolay Borisov
2019-05-09 13:14 ` David Sterba
0 siblings, 2 replies; 3+ messages in thread
From: Qu Wenruo @ 2019-05-09 7:31 UTC (permalink / raw)
To: linux-btrfs
At the context of btrfs_run_delalloc_range(), we haven't started/joined
a transaction, thus even something went wrong, we can't and won't abort
transaction, thus no way to make the fs RO.
Signed-off-by: Qu Wenruo <wqu@suse.com>
---
fs/btrfs/extent_io.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c
index 13fca7bfc1f2..85023bb322f0 100644
--- a/fs/btrfs/extent_io.c
+++ b/fs/btrfs/extent_io.c
@@ -3312,7 +3312,6 @@ static noinline_for_stack int writepage_delalloc(struct inode *inode,
}
ret = btrfs_run_delalloc_range(inode, page, delalloc_start,
delalloc_end, &page_started, nr_written, wbc);
- /* File system has been set read-only */
if (ret) {
SetPageError(page);
/*
--
2.21.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] btrfs: extent-io: Remove the incorrect comment on RO fs when btrfs_run_delalloc_range() fails
2019-05-09 7:31 [PATCH] btrfs: extent-io: Remove the incorrect comment on RO fs when btrfs_run_delalloc_range() fails Qu Wenruo
@ 2019-05-09 7:43 ` Nikolay Borisov
2019-05-09 13:14 ` David Sterba
1 sibling, 0 replies; 3+ messages in thread
From: Nikolay Borisov @ 2019-05-09 7:43 UTC (permalink / raw)
To: Qu Wenruo, linux-btrfs
On 9.05.19 г. 10:31 ч., Qu Wenruo wrote:
> At the context of btrfs_run_delalloc_range(), we haven't started/joined
> a transaction, thus even something went wrong, we can't and won't abort
> transaction, thus no way to make the fs RO.
>
> Signed-off-by: Qu Wenruo <wqu@suse.com>
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
> ---
> fs/btrfs/extent_io.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c
> index 13fca7bfc1f2..85023bb322f0 100644
> --- a/fs/btrfs/extent_io.c
> +++ b/fs/btrfs/extent_io.c
> @@ -3312,7 +3312,6 @@ static noinline_for_stack int writepage_delalloc(struct inode *inode,
> }
> ret = btrfs_run_delalloc_range(inode, page, delalloc_start,
> delalloc_end, &page_started, nr_written, wbc);
> - /* File system has been set read-only */
> if (ret) {
> SetPageError(page);
> /*
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] btrfs: extent-io: Remove the incorrect comment on RO fs when btrfs_run_delalloc_range() fails
2019-05-09 7:31 [PATCH] btrfs: extent-io: Remove the incorrect comment on RO fs when btrfs_run_delalloc_range() fails Qu Wenruo
2019-05-09 7:43 ` Nikolay Borisov
@ 2019-05-09 13:14 ` David Sterba
1 sibling, 0 replies; 3+ messages in thread
From: David Sterba @ 2019-05-09 13:14 UTC (permalink / raw)
To: Qu Wenruo; +Cc: linux-btrfs
On Thu, May 09, 2019 at 03:31:50PM +0800, Qu Wenruo wrote:
> At the context of btrfs_run_delalloc_range(), we haven't started/joined
> a transaction, thus even something went wrong, we can't and won't abort
> transaction, thus no way to make the fs RO.
>
> Signed-off-by: Qu Wenruo <wqu@suse.com>
Added to 5.3 queue, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-05-09 13:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-09 7:31 [PATCH] btrfs: extent-io: Remove the incorrect comment on RO fs when btrfs_run_delalloc_range() fails Qu Wenruo
2019-05-09 7:43 ` Nikolay Borisov
2019-05-09 13:14 ` David Sterba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).