linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] btrfs-progs: check: fix option parsing for -E
@ 2019-06-17 16:45 Adam Borowski
  2019-06-18 13:07 ` David Sterba
  0 siblings, 1 reply; 4+ messages in thread
From: Adam Borowski @ 2019-06-17 16:45 UTC (permalink / raw)
  To: David Sterba, linux-btrfs; +Cc: Adam Borowski

It has a mandatory argument, thus it always crashed.

Signed-off-by: Adam Borowski <kilobyte@angband.pl>
---
 check/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/check/main.c b/check/main.c
index 731c21d3..b2f0c810 100644
--- a/check/main.c
+++ b/check/main.c
@@ -9923,7 +9923,7 @@ int cmd_check(int argc, char **argv)
 			{ NULL, 0, NULL, 0}
 		};
 
-		c = getopt_long(argc, argv, "as:br:pEQ", long_options, NULL);
+		c = getopt_long(argc, argv, "as:br:pE:Q", long_options, NULL);
 		if (c < 0)
 			break;
 		switch(c) {
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] btrfs-progs: check: fix option parsing for -E
  2019-06-17 16:45 [PATCH] btrfs-progs: check: fix option parsing for -E Adam Borowski
@ 2019-06-18 13:07 ` David Sterba
  2019-07-28  6:47   ` Adam Borowski
  0 siblings, 1 reply; 4+ messages in thread
From: David Sterba @ 2019-06-18 13:07 UTC (permalink / raw)
  To: Adam Borowski; +Cc: David Sterba, linux-btrfs

On Mon, Jun 17, 2019 at 06:45:48PM +0200, Adam Borowski wrote:
> It has a mandatory argument, thus it always crashed.
> 
> Signed-off-by: Adam Borowski <kilobyte@angband.pl>

Applied, thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] btrfs-progs: check: fix option parsing for -E
  2019-06-18 13:07 ` David Sterba
@ 2019-07-28  6:47   ` Adam Borowski
  2019-07-30 17:33     ` David Sterba
  0 siblings, 1 reply; 4+ messages in thread
From: Adam Borowski @ 2019-07-28  6:47 UTC (permalink / raw)
  To: David Sterba, linux-btrfs; +Cc: Adam Borowski

> On Mon, Jun 17, 2019 at 06:45:48PM +0200, Adam Borowski wrote:
> > It has a mandatory argument, thus it always crashed.
>
> Applied, thanks.

Seems like this has fallen through the cracks -- could you please re-apply?

--8x--8x--8x--8x--8x--8x--8x--8x--8x--8x--8x--8x--8x--8x--8x--8x--8x--8x--8x--

It has a mandatory argument, thus it always crashed.

Signed-off-by: Adam Borowski <kilobyte@angband.pl>
---
 check/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/check/main.c b/check/main.c
index 0cc6fdba..866da8dc 100644
--- a/check/main.c
+++ b/check/main.c
@@ -9867,7 +9867,7 @@ static int cmd_check(const struct cmd_struct *cmd, int argc, char **argv)
 			{ NULL, 0, NULL, 0}
 		};
 
-		c = getopt_long(argc, argv, "as:br:pEQ", long_options, NULL);
+		c = getopt_long(argc, argv, "as:br:pE:Q", long_options, NULL);
 		if (c < 0)
 			break;
 		switch(c) {
-- 
2.22.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] btrfs-progs: check: fix option parsing for -E
  2019-07-28  6:47   ` Adam Borowski
@ 2019-07-30 17:33     ` David Sterba
  0 siblings, 0 replies; 4+ messages in thread
From: David Sterba @ 2019-07-30 17:33 UTC (permalink / raw)
  To: Adam Borowski; +Cc: David Sterba, linux-btrfs

On Sun, Jul 28, 2019 at 08:47:36AM +0200, Adam Borowski wrote:
> > On Mon, Jun 17, 2019 at 06:45:48PM +0200, Adam Borowski wrote:
> > > It has a mandatory argument, thus it always crashed.
> >
> > Applied, thanks.
> 
> Seems like this has fallen through the cracks -- could you please re-apply?

Dunno why it got lost, applied again, thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-07-30 17:33 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-17 16:45 [PATCH] btrfs-progs: check: fix option parsing for -E Adam Borowski
2019-06-18 13:07 ` David Sterba
2019-07-28  6:47   ` Adam Borowski
2019-07-30 17:33     ` David Sterba

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).