From: Qu Wenruo <wqu@suse.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH v1.2 0/3] btrfs: tree-checker: Add extent items check
Date: Fri, 9 Aug 2019 09:24:21 +0800 [thread overview]
Message-ID: <20190809012424.11420-1-wqu@suse.com> (raw)
Finally, we are going to add tree-checker support for extent items,
which includes:
- EXTENT_ITEM/METADATA_ITEM
Which futher contains inline backrefs of:
* TREE_BLOCK_REF
* SHARED_BLOCK_REF
* EXETNT_DATA_REF
* SHARED_DATA_REF
- TREE_BLOCK_REF
- SHARED_BLOCK_REF
- EXTENT_DATA_REF
- SHARED_DATA_REF
Keyed version of the above types
The complexity of the on-disk format can be found in the first patch,
which contains a basic introduction as comment.
Hidden pitfalls are everywhere, e.g. inlined EXTENT_DATA_REF don't use
iref->offset, but put its own data at iref->offset.
But SHARED_DATA_REF uses iref->offset, and put extra data after iref.
Such on-disk layout makes sense, but definitely a mess to read.
Thankfully we at least have print-tree code from btrfs-progs as a
reference.
Changelog:
v1.1:
- If branches optimization
Make some if branches more readable.
- Range notion update
Use regular set notion ([],[),(],()) to show possible value range.
- Fix a wrong range notion
The valid range for tree level is [0, MAX_LEVEL - 1], not
[0, MAX_LEVEL -1)
v1.2:
- Use "unsigned long" for pointer convertion
- Use "%zu" format for sizeof() in the 3rd patch
Qu Wenruo (3):
btrfs: tree-checker: Add EXTENT_ITEM and METADATA_ITEM check
btrfs: tree-checker: Add simple keyed refs check
btrfs: tree-checker: Add EXTENT_DATA_REF check
fs/btrfs/ctree.h | 1 +
fs/btrfs/extent-tree.c | 2 +-
fs/btrfs/tree-checker.c | 336 ++++++++++++++++++++++++++++++++++++++++
3 files changed, 338 insertions(+), 1 deletion(-)
--
2.22.0
next reply other threads:[~2019-08-09 1:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-09 1:24 Qu Wenruo [this message]
2019-08-09 1:24 ` [PATCH v1.2 1/3] btrfs: tree-checker: Add EXTENT_ITEM and METADATA_ITEM check Qu Wenruo
2019-08-22 14:59 ` David Sterba
2019-08-09 1:24 ` [PATCH v1.2 2/3] btrfs: tree-checker: Add simple keyed refs check Qu Wenruo
[not found] ` <CAKzB54SN1FmGhGHQOfT2fvn=ESQn4vOwbPpPM7p8eJRkNmvf7w@mail.gmail.com>
2019-08-09 4:25 ` Deletion on BTRFS - how does it work Alex Shashkov
2019-08-22 16:18 ` Nikolay Borisov
2019-08-22 15:02 ` [PATCH v1.2 2/3] btrfs: tree-checker: Add simple keyed refs check David Sterba
2019-08-09 1:24 ` [PATCH v1.2 3/3] btrfs: tree-checker: Add EXTENT_DATA_REF check Qu Wenruo
2019-08-22 15:08 ` [PATCH v1.2 0/3] btrfs: tree-checker: Add extent items check David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190809012424.11420-1-wqu@suse.com \
--to=wqu@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).