From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v1.2 0/3] btrfs: tree-checker: Add extent items check
Date: Thu, 22 Aug 2019 17:08:35 +0200 [thread overview]
Message-ID: <20190822150835.GJ2752@twin.jikos.cz> (raw)
In-Reply-To: <20190809012424.11420-1-wqu@suse.com>
On Fri, Aug 09, 2019 at 09:24:21AM +0800, Qu Wenruo wrote:
> Finally, we are going to add tree-checker support for extent items,
> which includes:
> - EXTENT_ITEM/METADATA_ITEM
> Which futher contains inline backrefs of:
> * TREE_BLOCK_REF
> * SHARED_BLOCK_REF
> * EXETNT_DATA_REF
> * SHARED_DATA_REF
>
> - TREE_BLOCK_REF
> - SHARED_BLOCK_REF
> - EXTENT_DATA_REF
> - SHARED_DATA_REF
> Keyed version of the above types
Great, thanks.
> v1.2:
^^^^
Please use integers for patchsets, ie. this is v3 for me.
> - Use "unsigned long" for pointer convertion
>
> - Use "%zu" format for sizeof() in the 3rd patch
>
> Qu Wenruo (3):
> btrfs: tree-checker: Add EXTENT_ITEM and METADATA_ITEM check
> btrfs: tree-checker: Add simple keyed refs check
> btrfs: tree-checker: Add EXTENT_DATA_REF check
I'll update patch 1 with the goto -> return and fix the comments, no
need to resend. V2 has been in for-next, there were no significant
changes since so I'll add v3 to misc-next. Thanks.
prev parent reply other threads:[~2019-08-22 15:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-09 1:24 [PATCH v1.2 0/3] btrfs: tree-checker: Add extent items check Qu Wenruo
2019-08-09 1:24 ` [PATCH v1.2 1/3] btrfs: tree-checker: Add EXTENT_ITEM and METADATA_ITEM check Qu Wenruo
2019-08-22 14:59 ` David Sterba
2019-08-09 1:24 ` [PATCH v1.2 2/3] btrfs: tree-checker: Add simple keyed refs check Qu Wenruo
[not found] ` <CAKzB54SN1FmGhGHQOfT2fvn=ESQn4vOwbPpPM7p8eJRkNmvf7w@mail.gmail.com>
2019-08-09 4:25 ` Deletion on BTRFS - how does it work Alex Shashkov
2019-08-22 16:18 ` Nikolay Borisov
2019-08-22 15:02 ` [PATCH v1.2 2/3] btrfs: tree-checker: Add simple keyed refs check David Sterba
2019-08-09 1:24 ` [PATCH v1.2 3/3] btrfs: tree-checker: Add EXTENT_DATA_REF check Qu Wenruo
2019-08-22 15:08 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190822150835.GJ2752@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).