* [PATCH] btrfs: removed unused return variable
@ 2019-09-30 11:17 Aliasgar Surti
2019-09-30 11:53 ` Nikolay Borisov
0 siblings, 1 reply; 3+ messages in thread
From: Aliasgar Surti @ 2019-09-30 11:17 UTC (permalink / raw)
To: clm, josef, dsterba, linux-btrfs; +Cc: Aliasgar Surti
From: Aliasgar Surti <aliasgar.surti500@gmail.com>
Removed unused return variable and replaced it with returning
the value directly
Signed-off-by: Aliasgar Surti <aliasgar.surti500@gmail.com>
---
fs/btrfs/disk-io.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
index 044981c..c80fa67 100644
--- a/fs/btrfs/disk-io.c
+++ b/fs/btrfs/disk-io.c
@@ -4255,7 +4255,6 @@ static int btrfs_destroy_delayed_refs(struct btrfs_transaction *trans,
struct rb_node *node;
struct btrfs_delayed_ref_root *delayed_refs;
struct btrfs_delayed_ref_node *ref;
- int ret = 0;
delayed_refs = &trans->delayed_refs;
@@ -4263,7 +4262,7 @@ static int btrfs_destroy_delayed_refs(struct btrfs_transaction *trans,
if (atomic_read(&delayed_refs->num_entries) == 0) {
spin_unlock(&delayed_refs->lock);
btrfs_info(fs_info, "delayed_refs has NO entry");
- return ret;
+ return 0;
}
while ((node = rb_first_cached(&delayed_refs->href_root)) != NULL) {
@@ -4307,7 +4306,7 @@ static int btrfs_destroy_delayed_refs(struct btrfs_transaction *trans,
spin_unlock(&delayed_refs->lock);
- return ret;
+ return 0;
}
static void btrfs_destroy_delalloc_inodes(struct btrfs_root *root)
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] btrfs: removed unused return variable
2019-09-30 11:17 [PATCH] btrfs: removed unused return variable Aliasgar Surti
@ 2019-09-30 11:53 ` Nikolay Borisov
2019-09-30 12:49 ` Aliasgar Surti
0 siblings, 1 reply; 3+ messages in thread
From: Nikolay Borisov @ 2019-09-30 11:53 UTC (permalink / raw)
To: Aliasgar Surti, clm, David Sterba, josef, linux-btrfs
On 30.09.19 г. 14:17 ч., Aliasgar Surti wrote:
> From: Aliasgar Surti <aliasgar.surti500@gmail.com>
>
> Removed unused return variable and replaced it with returning
> the value directly
>
> Signed-off-by: Aliasgar Surti <aliasgar.surti500@gmail.com>
Actually this function should be turned to void and even the declaration
at the top of disk-io can be removed.
> ---
> fs/btrfs/disk-io.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
> index 044981c..c80fa67 100644
> --- a/fs/btrfs/disk-io.c
> +++ b/fs/btrfs/disk-io.c
> @@ -4255,7 +4255,6 @@ static int btrfs_destroy_delayed_refs(struct btrfs_transaction *trans,
> struct rb_node *node;
> struct btrfs_delayed_ref_root *delayed_refs;
> struct btrfs_delayed_ref_node *ref;
> - int ret = 0;
>
> delayed_refs = &trans->delayed_refs;
>
> @@ -4263,7 +4262,7 @@ static int btrfs_destroy_delayed_refs(struct btrfs_transaction *trans,
> if (atomic_read(&delayed_refs->num_entries) == 0) {
> spin_unlock(&delayed_refs->lock);
> btrfs_info(fs_info, "delayed_refs has NO entry");
> - return ret;
> + return 0;
> }
>
> while ((node = rb_first_cached(&delayed_refs->href_root)) != NULL) {
> @@ -4307,7 +4306,7 @@ static int btrfs_destroy_delayed_refs(struct btrfs_transaction *trans,
>
> spin_unlock(&delayed_refs->lock);
>
> - return ret;
> + return 0;
> }
>
> static void btrfs_destroy_delalloc_inodes(struct btrfs_root *root)
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] btrfs: removed unused return variable
2019-09-30 11:53 ` Nikolay Borisov
@ 2019-09-30 12:49 ` Aliasgar Surti
0 siblings, 0 replies; 3+ messages in thread
From: Aliasgar Surti @ 2019-09-30 12:49 UTC (permalink / raw)
To: Nikolay Borisov; +Cc: clm, David Sterba, josef, linux-btrfs
On Mon, Sep 30, 2019 at 02:53:12PM +0300, Nikolay Borisov wrote:
>
>
> On 30.09.19 г. 14:17 ч., Aliasgar Surti wrote:
> > From: Aliasgar Surti <aliasgar.surti500@gmail.com>
> >
> > Removed unused return variable and replaced it with returning
> > the value directly
> >
> > Signed-off-by: Aliasgar Surti <aliasgar.surti500@gmail.com>
>
> Actually this function should be turned to void and even the declaration
> at the top of disk-io can be removed.
Okay, will send out v2 incorporating this change.
Thanks,
Aliasgar
>
> > ---
> > fs/btrfs/disk-io.c | 5 ++---
> > 1 file changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
> > index 044981c..c80fa67 100644
> > --- a/fs/btrfs/disk-io.c
> > +++ b/fs/btrfs/disk-io.c
> > @@ -4255,7 +4255,6 @@ static int btrfs_destroy_delayed_refs(struct btrfs_transaction *trans,
> > struct rb_node *node;
> > struct btrfs_delayed_ref_root *delayed_refs;
> > struct btrfs_delayed_ref_node *ref;
> > - int ret = 0;
> >
> > delayed_refs = &trans->delayed_refs;
> >
> > @@ -4263,7 +4262,7 @@ static int btrfs_destroy_delayed_refs(struct btrfs_transaction *trans,
> > if (atomic_read(&delayed_refs->num_entries) == 0) {
> > spin_unlock(&delayed_refs->lock);
> > btrfs_info(fs_info, "delayed_refs has NO entry");
> > - return ret;
> > + return 0;
> > }
> >
> > while ((node = rb_first_cached(&delayed_refs->href_root)) != NULL) {
> > @@ -4307,7 +4306,7 @@ static int btrfs_destroy_delayed_refs(struct btrfs_transaction *trans,
> >
> > spin_unlock(&delayed_refs->lock);
> >
> > - return ret;
> > + return 0;
> > }
> >
> > static void btrfs_destroy_delalloc_inodes(struct btrfs_root *root)
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-09-30 12:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-30 11:17 [PATCH] btrfs: removed unused return variable Aliasgar Surti
2019-09-30 11:53 ` Nikolay Borisov
2019-09-30 12:49 ` Aliasgar Surti
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).