From: Sebastian <sebastian.scherbel@fau.de>
To: dsterba@suse.com
Cc: josef@toxicpanda.com, clm@fb.com, linux-btrfs@vger.kernel.org,
linux-kernel@i4.cs.fau.de,
Sebastian Scherbel <sebastian.scherbel@fau.de>,
Ole Wiedemann <ole.wiedemann@fau.de>
Subject: [PATCH 3/5] fs_btrfs_ref-verify: code cleanup
Date: Tue, 10 Dec 2019 08:13:55 +0100 [thread overview]
Message-ID: <20191210071357.5323-4-sebastian.scherbel@fau.de> (raw)
In-Reply-To: <20191210071357.5323-1-sebastian.scherbel@fau.de>
From: Sebastian Scherbel <sebastian.scherbel@fau.de>
This patch changes several instances in ref-verify where the coding style
is not in line with the Linux kernel guidelines to improve readability.
1. inline keyword moved between storage class and type
2. missing space before the open parenthesis added
Signed-off-by: Sebastian Scherbel <sebastian.scherbel@fau.de>
Co-developed-by: Ole Wiedemann <ole.wiedemann@fau.de>
Signed-off-by: Ole Wiedemann <ole.wiedemann@fau.de>
---
fs/btrfs/ref-verify.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/btrfs/ref-verify.c b/fs/btrfs/ref-verify.c
index b57f3618e58e..be735e774d3a 100644
--- a/fs/btrfs/ref-verify.c
+++ b/fs/btrfs/ref-verify.c
@@ -218,11 +218,11 @@ static void __print_stack_trace(struct btrfs_fs_info *fs_info,
stack_trace_print(ra->trace, ra->trace_len, 2);
}
#else
-static void inline __save_stack_trace(struct ref_action *ra)
+static inline void __save_stack_trace(struct ref_action *ra)
{
}
-static void inline __print_stack_trace(struct btrfs_fs_info *fs_info,
+static inline void __print_stack_trace(struct btrfs_fs_info *fs_info,
struct ref_action *ra)
{
btrfs_err(fs_info, " ref-verify: no stacktrace support");
@@ -242,7 +242,7 @@ static void free_block_entry(struct block_entry *be)
kfree(re);
}
- while((n = rb_first(&be->refs))) {
+ while ((n = rb_first(&be->refs))) {
ref = rb_entry(n, struct ref_entry, node);
rb_erase(&ref->node, &be->refs);
kfree(ref);
--
2.20.1
next prev parent reply other threads:[~2019-12-10 7:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 7:13 [PATCH 0/5] btrfs: code cleanup Sebastian
2019-12-10 7:13 ` [PATCH 1/5] fs_btrfs_sysfs: " Sebastian
2019-12-10 7:13 ` [PATCH 2/5] fs_btrfs_struct-funcs: " Sebastian
2019-12-10 7:13 ` Sebastian [this message]
2019-12-10 7:13 ` [PATCH 4/5] fs_btrfs_qgroup: " Sebastian
2019-12-10 7:13 ` [PATCH 5/5] fs_btrfs_block-group: " Sebastian
2019-12-10 12:19 ` [PATCH 0/5] btrfs: " David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191210071357.5323-4-sebastian.scherbel@fau.de \
--to=sebastian.scherbel@fau.de \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@i4.cs.fau.de \
--cc=ole.wiedemann@fau.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).