From: David Sterba <dsterba@suse.cz>
To: Sebastian <sebastian.scherbel@fau.de>
Cc: dsterba@suse.com, josef@toxicpanda.com, clm@fb.com,
linux-btrfs@vger.kernel.org, linux-kernel@i4.cs.fau.de
Subject: Re: [PATCH 0/5] btrfs: code cleanup
Date: Tue, 10 Dec 2019 13:19:55 +0100 [thread overview]
Message-ID: <20191210121955.GT2734@twin.jikos.cz> (raw)
In-Reply-To: <20191210071357.5323-1-sebastian.scherbel@fau.de>
On Tue, Dec 10, 2019 at 08:13:52AM +0100, Sebastian wrote:
> From: Sebastian Scherbel <sebastian.scherbel@fau.de>
>
> This patch series changes several instances in btrfs where the coding style
> is not in line with the Linux kernel guidelines to improve readability.
Please don't do that. This has happened enough times that we have a FAQ
entry about that and I can recommend reading the whole section, from
which I quote the first part:
https://btrfs.wiki.kernel.org/index.php/Developer%27s_FAQ#How_not_to_start
"It might be tempting to look for coding style violations and send
patches to fix them. This happens from time to time and the community
does not welcome that. [...]"
prev parent reply other threads:[~2019-12-10 12:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 7:13 [PATCH 0/5] btrfs: code cleanup Sebastian
2019-12-10 7:13 ` [PATCH 1/5] fs_btrfs_sysfs: " Sebastian
2019-12-10 7:13 ` [PATCH 2/5] fs_btrfs_struct-funcs: " Sebastian
2019-12-10 7:13 ` [PATCH 3/5] fs_btrfs_ref-verify: " Sebastian
2019-12-10 7:13 ` [PATCH 4/5] fs_btrfs_qgroup: " Sebastian
2019-12-10 7:13 ` [PATCH 5/5] fs_btrfs_block-group: " Sebastian
2019-12-10 12:19 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191210121955.GT2734@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@i4.cs.fau.de \
--cc=sebastian.scherbel@fau.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).