* [PATCH] btrfs-progs: disk-io: Remove duplicated ASSERT() call
@ 2019-12-10 7:52 Qu Wenruo
2020-01-02 17:14 ` David Sterba
0 siblings, 1 reply; 2+ messages in thread
From: Qu Wenruo @ 2019-12-10 7:52 UTC (permalink / raw)
To: linux-btrfs
There are two ASSERT() with completely the same check introduced in
commit f7717d8cdb7d ("btrfs-progs: Remove fsid/metdata_uuid fields
from fs_info").
Just remove it.
Fixes: f7717d8cdb7d ("btrfs-progs: Remove fsid/metdata_uuid fields from fs_info")
Signed-off-by: Qu Wenruo <wqu@suse.com>
---
disk-io.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/disk-io.c b/disk-io.c
index 659f8b93a7ca..8fe811e861fc 100644
--- a/disk-io.c
+++ b/disk-io.c
@@ -1248,7 +1248,6 @@ static struct btrfs_fs_info *__open_ctree_fd(int fp, const char *path,
goto out_devices;
}
- ASSERT(!memcmp(disk_super->fsid, fs_devices->fsid, BTRFS_FSID_SIZE));
ASSERT(!memcmp(disk_super->fsid, fs_devices->fsid, BTRFS_FSID_SIZE));
if (btrfs_fs_incompat(fs_info, METADATA_UUID))
ASSERT(!memcmp(disk_super->metadata_uuid,
--
2.24.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] btrfs-progs: disk-io: Remove duplicated ASSERT() call
2019-12-10 7:52 [PATCH] btrfs-progs: disk-io: Remove duplicated ASSERT() call Qu Wenruo
@ 2020-01-02 17:14 ` David Sterba
0 siblings, 0 replies; 2+ messages in thread
From: David Sterba @ 2020-01-02 17:14 UTC (permalink / raw)
To: Qu Wenruo; +Cc: linux-btrfs
On Tue, Dec 10, 2019 at 03:52:02PM +0800, Qu Wenruo wrote:
> There are two ASSERT() with completely the same check introduced in
> commit f7717d8cdb7d ("btrfs-progs: Remove fsid/metdata_uuid fields
> from fs_info").
>
> Just remove it.
>
> Fixes: f7717d8cdb7d ("btrfs-progs: Remove fsid/metdata_uuid fields from fs_info")
> Signed-off-by: Qu Wenruo <wqu@suse.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-02 17:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-10 7:52 [PATCH] btrfs-progs: disk-io: Remove duplicated ASSERT() call Qu Wenruo
2020-01-02 17:14 ` David Sterba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).