From: Goffredo Baroncelli <kreijack@libero.it>
To: linux-btrfs@vger.kernel.org
Cc: Zygo Blaxell <ce3g8jdj@umail.furryterror.org>,
Goffredo Baroncelli <kreijack@inwind.it>
Subject: [PATCH 3/4] btrfs-progs: Add btrfs_check_for_mixed_profiles_by_* function
Date: Wed, 25 Mar 2020 21:10:41 +0100 [thread overview]
Message-ID: <20200325201042.190332-4-kreijack@libero.it> (raw)
In-Reply-To: <20200325201042.190332-1-kreijack@libero.it>
From: Goffredo Baroncelli <kreijack@inwind.it>
Show a warning if a mixed profiles filesystem
is detected.
Signed-off-by: Goffredo Baroncelli <kreijack@inwind.it>
---
common/utils.c | 126 +++++++++++++++++++++++++++++++++++++++++++++++++
common/utils.h | 3 ++
2 files changed, 129 insertions(+)
diff --git a/common/utils.c b/common/utils.c
index 4ce36836..e7cd66eb 100644
--- a/common/utils.c
+++ b/common/utils.c
@@ -1710,3 +1710,129 @@ void print_all_devices(struct list_head *devices)
print_device_info(dev, "\t");
printf("\n");
}
+
+static int bit_count(u64 x)
+{
+ int ret = 0;
+
+ while (x) {
+ if (x & 1)
+ ret++;
+ x >>= 1;
+ }
+ return ret;
+}
+
+static void print_profiles(FILE *out, u64 profiles)
+{
+ int i;
+ int first = true;
+
+ for (i = 0 ; i < BTRFS_NR_RAID_TYPES ; i++) {
+ if (!(btrfs_raid_array[i].bg_flag & profiles))
+ continue;
+
+ if (!first)
+ fprintf(out, ", ");
+ fprintf(out, "%s", btrfs_raid_array[i].raid_name);
+ first = false;
+ }
+ if (profiles & BTRFS_AVAIL_ALLOC_BIT_SINGLE) {
+ if (!first)
+ fprintf(out, ", ");
+ fprintf(out, "%s",
+ btrfs_raid_array[BTRFS_RAID_SINGLE].raid_name);
+ }
+}
+
+int btrfs_check_for_mixed_profiles_by_path(char *path)
+{
+ int fd;
+ int ret;
+ DIR *dirstream;
+
+ fd = btrfs_open_dir(path, &dirstream, 0);
+ if (fd < 0)
+ return -1;
+ closedir(dirstream);
+
+ ret = btrfs_check_for_mixed_profiles_by_fd(fd);
+ close(fd);
+
+ return ret;
+}
+
+int btrfs_check_for_mixed_profiles_by_fd(int fd)
+{
+ int ret;
+ int i;
+ struct btrfs_ioctl_space_args *sargs;
+ u64 data_profiles = 0;
+ u64 metadata_profiles = 0;
+ u64 system_profiles = 0;
+ u64 mixed_profiles = 0;
+ static const u64 mixed_profile_fl = BTRFS_BLOCK_GROUP_METADATA |
+ BTRFS_BLOCK_GROUP_DATA;
+
+ ret = get_df(fd, &sargs);
+ if (ret < 0)
+ return -1;
+
+ for (i = 0 ; i < sargs->total_spaces ; i++) {
+ u64 flags = sargs->spaces[i].flags;
+
+ if (!(flags & BTRFS_BLOCK_GROUP_PROFILE_MASK))
+ flags |= BTRFS_AVAIL_ALLOC_BIT_SINGLE;
+
+ if ((flags & mixed_profile_fl) == mixed_profile_fl)
+ mixed_profiles |= flags;
+ else if (flags & BTRFS_BLOCK_GROUP_DATA)
+ data_profiles |= flags;
+ else if (flags & BTRFS_BLOCK_GROUP_METADATA)
+ metadata_profiles |= flags;
+ else if (flags & BTRFS_BLOCK_GROUP_SYSTEM)
+ system_profiles |= flags;
+ }
+ free(sargs);
+
+ data_profiles &= BTRFS_EXTENDED_PROFILE_MASK;
+ system_profiles &= BTRFS_EXTENDED_PROFILE_MASK;
+ mixed_profiles &= BTRFS_EXTENDED_PROFILE_MASK;
+ metadata_profiles &= BTRFS_EXTENDED_PROFILE_MASK;
+
+ if ((bit_count(data_profiles) <= 1) &&
+ (bit_count(metadata_profiles) <= 1) &&
+ (bit_count(system_profiles) <= 1) &&
+ (bit_count(mixed_profiles) <= 1))
+ return 0;
+
+ fprintf(stderr, "WARNING: ------------------------------------------------------\n");
+ fprintf(stderr, "WARNING: Detection of multiple profiles for a block group type:\n");
+ fprintf(stderr, "WARNING:\n");
+ if (bit_count(data_profiles) > 1) {
+ fprintf(stderr, "WARNING: * DATA -> [");
+ print_profiles(stderr, data_profiles);
+ fprintf(stderr, "]\n");
+ }
+ if (bit_count(metadata_profiles) > 1) {
+ fprintf(stderr, "WARNING: * METADATA -> [");
+ print_profiles(stderr, metadata_profiles);
+ fprintf(stderr, "]\n");
+ }
+ if (bit_count(mixed_profiles) > 1) {
+ fprintf(stderr, "WARNING: * DATA+METADATA -> [");
+ print_profiles(stderr, mixed_profiles);
+ fprintf(stderr, "]\n");
+ }
+ if (bit_count(system_profiles) > 1) {
+ fprintf(stderr, "WARNING: * SYSTEM -> [");
+ print_profiles(stderr, system_profiles);
+ fprintf(stderr, "]\n");
+ }
+ fprintf(stderr, "WARNING:\n");
+ fprintf(stderr, "WARNING: Please consider using 'btrfs balance ...' commands set\n");
+ fprintf(stderr, "WARNING: to solve this issue.\n");
+ fprintf(stderr, "WARNING: ------------------------------------------------------\n");
+
+ return 1;
+}
diff --git a/common/utils.h b/common/utils.h
index 5c1afda9..662c9e38 100644
--- a/common/utils.h
+++ b/common/utils.h
@@ -137,4 +137,7 @@ u64 rand_u64(void);
unsigned int rand_range(unsigned int upper);
void init_rand_seed(u64 seed);
+int btrfs_check_for_mixed_profiles_by_path(char *path);
+int btrfs_check_for_mixed_profiles_by_fd(int fd);
+
#endif
--
2.26.0.rc2
next prev parent reply other threads:[~2020-03-25 20:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 20:10 [RFC][PATCH] btrfs-progs: add warning for mixed prfofiles filesystem Goffredo Baroncelli
2020-03-25 20:10 ` [PATCH 1/4] btrfs-progs: Add missing fields to btrfs_raid_array[] for raid1c[34] Goffredo Baroncelli
2020-03-26 1:59 ` Qu Wenruo
2020-03-26 17:28 ` Goffredo Baroncelli
2020-03-25 20:10 ` [PATCH 2/4] btrfs-progs: Add BTRFS_EXTENDED_PROFILE_MASK mask Goffredo Baroncelli
2020-03-25 20:10 ` Goffredo Baroncelli [this message]
2020-03-25 20:10 ` [PATCH 4/4] btrfs-progs: Add mixed profiles check to 'btrfs fi us' Goffredo Baroncelli
2020-03-31 19:10 [PATCH v2] btrfs-progs: add warning for mixed profiles filesystem Goffredo Baroncelli
2020-03-31 19:10 ` [PATCH 3/4] btrfs-progs: Add btrfs_check_for_mixed_profiles_by_* function Goffredo Baroncelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200325201042.190332-4-kreijack@libero.it \
--to=kreijack@libero.it \
--cc=ce3g8jdj@umail.furryterror.org \
--cc=kreijack@inwind.it \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).