linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] btrfs: Remove unused variable 'fs_info'
@ 2020-08-26  6:27 YueHaibing
  2020-08-26 10:48 ` David Sterba
  0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2020-08-26  6:27 UTC (permalink / raw)
  To: clm, josef, dsterba; +Cc: linux-btrfs, linux-kernel, YueHaibing

fs/btrfs/volumes.c: In function ‘btrfs_rm_dev_replace_free_srcdev’:
fs/btrfs/volumes.c:2217:24: warning: unused variable ‘fs_info’ [-Wunused-variable]
  struct btrfs_fs_info *fs_info = srcdev->fs_info;
                        ^~~~~~~

Caused by commit 65237ee3b6b3 ("btrfs: get fs_info from device
in btrfs_rm_dev_replace_free_srcdev")

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 fs/btrfs/volumes.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index ec62fc0ec113..b775ed5d3737 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -2214,7 +2214,6 @@ void btrfs_rm_dev_replace_remove_srcdev(struct btrfs_device *srcdev)
 
 void btrfs_rm_dev_replace_free_srcdev(struct btrfs_device *srcdev)
 {
-	struct btrfs_fs_info *fs_info = srcdev->fs_info;
 	struct btrfs_fs_devices *fs_devices = srcdev->fs_devices;
 
 	mutex_lock(&uuid_mutex);
-- 
2.17.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] btrfs: Remove unused variable 'fs_info'
  2020-08-26  6:27 [PATCH -next] btrfs: Remove unused variable 'fs_info' YueHaibing
@ 2020-08-26 10:48 ` David Sterba
  0 siblings, 0 replies; 2+ messages in thread
From: David Sterba @ 2020-08-26 10:48 UTC (permalink / raw)
  To: YueHaibing; +Cc: clm, josef, dsterba, linux-btrfs, linux-kernel

On Wed, Aug 26, 2020 at 02:27:52PM +0800, YueHaibing wrote:
> fs/btrfs/volumes.c: In function ‘btrfs_rm_dev_replace_free_srcdev’:
> fs/btrfs/volumes.c:2217:24: warning: unused variable ‘fs_info’ [-Wunused-variable]
>   struct btrfs_fs_info *fs_info = srcdev->fs_info;
>                         ^~~~~~~
> 
> Caused by commit 65237ee3b6b3 ("btrfs: get fs_info from device
> in btrfs_rm_dev_replace_free_srcdev")
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Fixed in for-next, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-08-26 10:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-26  6:27 [PATCH -next] btrfs: Remove unused variable 'fs_info' YueHaibing
2020-08-26 10:48 ` David Sterba

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).