* [PATCH] btrfs: tree-checker: fix the error message for transid error
@ 2020-08-25 13:42 Qu Wenruo
2020-08-25 13:55 ` Marcos Paulo de Souza
2020-08-26 11:17 ` David Sterba
0 siblings, 2 replies; 3+ messages in thread
From: Qu Wenruo @ 2020-08-25 13:42 UTC (permalink / raw)
To: linux-btrfs; +Cc: Tyler Richmond
The error message for inode transid is the same for inode generation,
which makes us unable to detect the real problem.
Reported-by: Tyler Richmond <t.d.richmond@gmail.com>
Fixes: 496245cac57e ("btrfs: tree-checker: Verify inode item")
Signed-off-by: Qu Wenruo <wqu@suse.com>
---
fs/btrfs/tree-checker.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/btrfs/tree-checker.c b/fs/btrfs/tree-checker.c
index 517b44300a05..7b1fee630f97 100644
--- a/fs/btrfs/tree-checker.c
+++ b/fs/btrfs/tree-checker.c
@@ -984,7 +984,7 @@ static int check_inode_item(struct extent_buffer *leaf,
/* Note for ROOT_TREE_DIR_ITEM, mkfs could set its transid 0 */
if (btrfs_inode_transid(leaf, iitem) > super_gen + 1) {
inode_item_err(leaf, slot,
- "invalid inode generation: has %llu expect [0, %llu]",
+ "invalid inode transid: has %llu expect [0, %llu]",
btrfs_inode_transid(leaf, iitem), super_gen + 1);
return -EUCLEAN;
}
--
2.28.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] btrfs: tree-checker: fix the error message for transid error
2020-08-25 13:42 [PATCH] btrfs: tree-checker: fix the error message for transid error Qu Wenruo
@ 2020-08-25 13:55 ` Marcos Paulo de Souza
2020-08-26 11:17 ` David Sterba
1 sibling, 0 replies; 3+ messages in thread
From: Marcos Paulo de Souza @ 2020-08-25 13:55 UTC (permalink / raw)
To: Qu Wenruo, linux-btrfs; +Cc: Tyler Richmond
On Tue, 2020-08-25 at 21:42 +0800, Qu Wenruo wrote:
> The error message for inode transid is the same for inode generation,
> which makes us unable to detect the real problem.
LGTM,
Reviewed-by: Marcos Paulo de Souza <mpdesouza@suse.com>
>
> Reported-by: Tyler Richmond <t.d.richmond@gmail.com>
> Fixes: 496245cac57e ("btrfs: tree-checker: Verify inode item")
> Signed-off-by: Qu Wenruo <wqu@suse.com>
> ---
> fs/btrfs/tree-checker.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/tree-checker.c b/fs/btrfs/tree-checker.c
> index 517b44300a05..7b1fee630f97 100644
> --- a/fs/btrfs/tree-checker.c
> +++ b/fs/btrfs/tree-checker.c
> @@ -984,7 +984,7 @@ static int check_inode_item(struct extent_buffer
> *leaf,
> /* Note for ROOT_TREE_DIR_ITEM, mkfs could set its transid 0 */
> if (btrfs_inode_transid(leaf, iitem) > super_gen + 1) {
> inode_item_err(leaf, slot,
> - "invalid inode generation: has %llu expect [0,
> %llu]",
> + "invalid inode transid: has %llu expect [0,
> %llu]",
> btrfs_inode_transid(leaf, iitem),
> super_gen + 1);
> return -EUCLEAN;
> }
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] btrfs: tree-checker: fix the error message for transid error
2020-08-25 13:42 [PATCH] btrfs: tree-checker: fix the error message for transid error Qu Wenruo
2020-08-25 13:55 ` Marcos Paulo de Souza
@ 2020-08-26 11:17 ` David Sterba
1 sibling, 0 replies; 3+ messages in thread
From: David Sterba @ 2020-08-26 11:17 UTC (permalink / raw)
To: Qu Wenruo; +Cc: linux-btrfs, Tyler Richmond
On Tue, Aug 25, 2020 at 09:42:51PM +0800, Qu Wenruo wrote:
> The error message for inode transid is the same for inode generation,
> which makes us unable to detect the real problem.
>
> Reported-by: Tyler Richmond <t.d.richmond@gmail.com>
> Fixes: 496245cac57e ("btrfs: tree-checker: Verify inode item")
> Signed-off-by: Qu Wenruo <wqu@suse.com>
Added to misc-next, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-26 11:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-25 13:42 [PATCH] btrfs: tree-checker: fix the error message for transid error Qu Wenruo
2020-08-25 13:55 ` Marcos Paulo de Souza
2020-08-26 11:17 ` David Sterba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).