Re: [PATCH v2 3/9] lib: zstd: Upgrade to latest upstream zstd version 1.4.6

Re: [PATCH v2 3/9] lib: zstd: Upgrade to latest upstream zstd version 1.4.6

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 5437 bytes --]

Hi Nick,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on kdave/for-next]
[also build test WARNING on f2fs/dev-test linus/master v5.9-rc6 next-20200923]
[cannot apply to cryptodev/master crypto/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Nick-Terrell/Update-to-zstd-1-4-6/20200923-050834
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-next
config: parisc-randconfig-r006-20200923 (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=parisc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from lib/zstd/compress/zstd_compress_internal.h:21,
                    from lib/zstd/compress/zstd_opt.c:11:
   lib/zstd/compress/../common/zstd_internal.h:215:18: warning: 'OF_defaultNormLog' defined but not used [-Wunused-const-variable=]
     215 | static const U32 OF_defaultNormLog = OF_DEFAULTNORMLOG;
         |                  ^~~~~~~~~~~~~~~~~
   lib/zstd/compress/../common/zstd_internal.h:210:18: warning: 'OF_defaultNorm' defined but not used [-Wunused-const-variable=]
     210 | static const S16 OF_defaultNorm[DefaultMaxOff+1] = { 1, 1, 1, 1, 1, 1, 2, 2,
         |                  ^~~~~~~~~~~~~~
   lib/zstd/compress/../common/zstd_internal.h:208:18: warning: 'ML_defaultNormLog' defined but not used [-Wunused-const-variable=]
     208 | static const U32 ML_defaultNormLog = ML_DEFAULTNORMLOG;
         |                  ^~~~~~~~~~~~~~~~~
   lib/zstd/compress/../common/zstd_internal.h:200:18: warning: 'ML_defaultNorm' defined but not used [-Wunused-const-variable=]
     200 | static const S16 ML_defaultNorm[MaxML+1] = { 1, 4, 3, 2, 2, 2, 2, 2,
         |                  ^~~~~~~~~~~~~~
   lib/zstd/compress/../common/zstd_internal.h:191:18: warning: 'LL_defaultNormLog' defined but not used [-Wunused-const-variable=]
     191 | static const U32 LL_defaultNormLog = LL_DEFAULTNORMLOG;
         |                  ^~~~~~~~~~~~~~~~~
   lib/zstd/compress/../common/zstd_internal.h:185:18: warning: 'LL_defaultNorm' defined but not used [-Wunused-const-variable=]
     185 | static const S16 LL_defaultNorm[MaxLL+1] = { 4, 3, 2, 2, 2, 2, 2, 2,
         |                  ^~~~~~~~~~~~~~
   In file included from lib/zstd/compress/zstd_compress_internal.h:21,
                    from lib/zstd/compress/zstd_opt.c:11:
   lib/zstd/compress/../common/zstd_internal.h:148:21: warning: 'ZSTD_did_fieldSize' defined but not used [-Wunused-const-variable=]
     148 | static const size_t ZSTD_did_fieldSize[4] = { 0, 1, 2, 4 };
         |                     ^~~~~~~~~~~~~~~~~~
   lib/zstd/compress/../common/zstd_internal.h:147:21: warning: 'ZSTD_fcs_fieldSize' defined but not used [-Wunused-const-variable=]
     147 | static const size_t ZSTD_fcs_fieldSize[4] = { 0, 2, 4, 8 };
         |                     ^~~~~~~~~~~~~~~~~~
   lib/zstd/compress/../common/zstd_internal.h:133:18: warning: 'repStartValue' defined but not used [-Wunused-const-variable=]
     133 | static const U32 repStartValue[ZSTD_REP_NUM] = { 1, 4, 8 };
         |                  ^~~~~~~~~~~~~
   In file included from lib/zstd/compress/../common/zstd_internal.h:27,
                    from lib/zstd/compress/zstd_compress_internal.h:21,
                    from lib/zstd/compress/zstd_opt.c:11:
   include/linux/zstd.h:1377:29: warning: 'ZSTD_defaultCMem' defined but not used [-Wunused-const-variable=]
    1377 | static ZSTD_customMem const ZSTD_defaultCMem = { NULL, NULL, NULL };  /**< this constant defers to stdlib's functions */
         |                             ^~~~~~~~~~~~~~~~
   lib/zstd/compress/zstd_opt.c: In function 'ZSTD_compressBlock_btopt_dictMatchState':
>> lib/zstd/compress/zstd_opt.c:1175:1: warning: the frame size of 1780 bytes is larger than 1280 bytes [-Wframe-larger-than=]
    1175 | }
         | ^
   lib/zstd/compress/zstd_opt.c: In function 'ZSTD_compressBlock_btultra_dictMatchState':
   lib/zstd/compress/zstd_opt.c:1182:1: warning: the frame size of 1776 bytes is larger than 1280 bytes [-Wframe-larger-than=]
    1182 | }
         | ^

# https://github.com/0day-ci/linux/commit/e06aaf2f403bed8f3012d673e07723ab5f752018
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Nick-Terrell/Update-to-zstd-1-4-6/20200923-050834
git checkout e06aaf2f403bed8f3012d673e07723ab5f752018
vim +1175 lib/zstd/compress/zstd_opt.c

  1169	
  1170	size_t ZSTD_compressBlock_btopt_dictMatchState(
  1171	        ZSTD_matchState_t* ms, seqStore_t* seqStore, U32 rep[ZSTD_REP_NUM],
  1172	        const void* src, size_t srcSize)
  1173	{
  1174	    return ZSTD_compressBlock_opt_generic(ms, seqStore, rep, src, srcSize, 0 /*optLevel*/, ZSTD_dictMatchState);
> 1175	}
  1176	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 28031 bytes --]